From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 269FB43B3A; Sun, 18 Feb 2024 14:45:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC98C40262; Sun, 18 Feb 2024 14:45:26 +0100 (CET) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 210324021D for ; Sun, 18 Feb 2024 14:45:25 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 8343F3200A0A; Sun, 18 Feb 2024 08:45:22 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 18 Feb 2024 08:45:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1708263922; x=1708350322; bh=Opn6YxYrLOgp+/RR0PaaRt7m5q2Ln2ysDliJaF2rZvw=; b= zO3I+WNiLKhUsAq+GWTTnmK0UYTHshvU/ksw+jxj9RGrE+Ok/HiFVGTvaBkScDy9 dunjsrjS/gzFvz+y102yLJ8IohLcSfMbj10mFDzSBZ9iSn6Gf9n+MnxWL2SMCmSS B3+c8O+5rUa1LTQE0LU1HGdo1Shphfe+T+7qcmhrhTlmx906m/847MtUUtadDHEF dusmDIYm6RjLaUO5fVk3DY1wvpUtM06eQlonA5xt2twyrvWqz1L/drUVA6BJki9K wKPVik56V4JZcuFW7h7kKeo24F8MMmIWncvJ5LankhzADKSRDQkIsDJ9kDmh3lNT XV3y/w6EmdAqN/njLaT/rw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708263922; x= 1708350322; bh=Opn6YxYrLOgp+/RR0PaaRt7m5q2Ln2ysDliJaF2rZvw=; b=b Cb4KG1W3YT+WCLFJGlt04Azexaz4bjRGedcoDfXaaZd3gWZKgfxkDaoGUxcamJlO Hl149xtll1OhGY26Se0C3MRNkRfw+OiFxA0u28V1Zt4pyuzQ+yKebf2UKKxlBDvC ogxJp504GCxvUWZHd4p2tw04eMzYiBDr1HvT1zRelg32ljBWsCBkInjPtBNZwCNb XQ++sgLl9HaAn+Iwqv+2VIvLfUn6SjkCu3Imqr4FuhITyBWL5PXREOBx1a1dGGUY bCkJdlQ2D7qQPv2tRYCLmbwuARoaJoTGsUV44+db4k+eKuxj55xJ1ucc/7cfZSB1 6S8uRpE1AvQIdKvjJYL1A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeigdehjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 18 Feb 2024 08:45:21 -0500 (EST) From: Thomas Monjalon To: Ric Li Cc: Bruce Richardson , dev@dpdk.org, david.marchand@redhat.com Subject: Re: [PATCH v2 1/2] build: fix list_dir_globs failure in MSYS2 Date: Sun, 18 Feb 2024 14:45:20 +0100 Message-ID: <10465276.VV5PYv0bhD@thomas> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Any update? Would you like to provide a v3? 24/10/2023 18:08, Ric Li: > > On 2023/10/11 23:34, Bruce Richardson wrote: > > On Wed, Oct 11, 2023 at 05:27:22PM +0200, Thomas Monjalon wrote: > >> 20/09/2023 16:18, Ric Li: > >>> When running 'meson setup' on Windows with MSYS2, > >>> "list-dir-globs.py * failed with status 1". > >> > >> We don't know why it is failing? > >> What about other usages of list_dir_globs in drivers and lib? > > Looks lile MSYS2 shell expands this wildcard automatically > before passing it to the child process. > > I print the args in list-dir-globs.py and found that args are > the expanded dir names, so the len(sys.argv) is larger than 2, > which makes this script fail. The '*/*' arg in drivers/meson.build > works well just as expected, and no '*' used in lib. > > This is from MSYS2 documentation: > "Windows programs parse the command line themselves, it isn't parsed for them by > the calling process, as on Linux. This means that if wildcards (glob patterns) are > to be accepted by the program, it has to be able to expand them somehow. MinGW-w64 > supplies the correct start-up code, so it happens automatically, in a manner > compatible with MSVC-compiled programs. If undesirable, the behavior can be > disabled at program build." > > I think this fix is not needed if we can find a way to disable the auto-expanding > behaviour of the MSYS2 program. I've tried the runtime way by setting > "MSYS=noglob" envvar but not working here... > > >> > >>> Avoid using globbing to get components for app build > >>> since they are already listed in the meson file. > >> > >> I don't understand the logic. > >> > >>> +disable_apps = ',' + get_option('disable_apps') > >>> +disable_apps = run_command(list_dir_globs, disable_apps, check: true).stdout().split() > >> > >> This could fail.>> > >>> + > >>> +enable_apps = ',' + get_option('enable_apps') > >>> +enable_apps = run_command(list_dir_globs, enable_apps, check: true).stdout().split() > >>> +if enable_apps.length() == 0 > >>> + enable_apps = apps > >>> +endif > >> > >> If nothing is enabled, we enable all? > >> > > Yes, if the enable_apps list is empty we should enable everything. > > However, on reviewing the v2, I missed the fact that this patch is > > removing the expansion of the disable_apps value.> > > Given your comment, this check can probably also be improved by checking > > the get_option('enable_apps') length, rather than the expanded version. > > > > /Bruce >