From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BFCB9A327F for ; Mon, 21 Oct 2019 22:10:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 896501BEAE; Mon, 21 Oct 2019 22:10:20 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id CAB691BDFD for ; Mon, 21 Oct 2019 22:10:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571688618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oHxmQmDoZo7+Sz8SGLtdchrlyOBmc65zGs0Ycjlrk+g=; b=JbL9G63ovak8JbQpp4s3uX8+NrUQE6lbrziwwNN9YDKfo+tJQ6u/aKHLYbKRR5cdEqvshs myH0kVnqXGSXk+ZxegGw2bWoX6/e34ziUE+ynZzqs43+WT/5kudxrpPCldS8faujEO+wTX qsicXiolrSNQa9nMCNNPVumn+cX4Zr8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-316-N2dl41vqN268RhFgFIoeVw-1; Mon, 21 Oct 2019 16:10:10 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A9E7847B; Mon, 21 Oct 2019 20:10:09 +0000 (UTC) Received: from [10.36.118.52] (unknown [10.36.118.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3422A6012A; Mon, 21 Oct 2019 20:10:08 +0000 (UTC) To: Rasesh Mody , "dev@dpdk.org" , Jerin Jacob Kollanukkaran , "ferruh.yigit@intel.com" Cc: GR-Everest-DPDK-Dev References: From: Kevin Traynor Message-ID: <104ba120-693c-fcd5-70dd-df0293f6e295@redhat.com> Date: Mon, 21 Oct 2019 21:10:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: N2dl41vqN268RhFgFIoeVw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/3] net/qede/base: fix for FW bug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 21/10/2019 19:52, Rasesh Mody wrote: > Hi Kevin, >=20 >> From: Kevin Traynor >> Sent: Monday, October 21, 2019 3:58 AM >> >> ---------------------------------------------------------------------- >> On 20/10/2019 06:20, Rasesh Mody wrote: >>> In our testing we have identified a critical FW bug. Performance is >>> degraded significantly for certain packet sizes with 8.40.25.0 FW. >>> >>> This patch updates the FW to version 8.40.33.0. The updated FW has a >>> fix to performance issue. >>> >>> The patch also adds initialization for FW overlay RAM as part of >>> hardware initialization which is required by the new FW. >>> >>> Fixes: 066f0d380a2f ("net/qede/base: update FW to 8.40.25.0") >>> >> >> Hi Rasesh, it should be: >> >> Fixes: 21c959e2cb10 ("net/qede/base: update FW to 8.40.25.0") >> >=20 > I could not find the 21c959e2cb10 reference, can you please let me know w= hich tree is it coming from? >=20 dpdk-next-net and dpdk-next-net-brcm trees. The commit doesn't seem to be in dpdk tree yet. >>> Signed-off-by: Rasesh Mody >>> --- >>> doc/guides/nics/qede.rst | 4 +- >>> drivers/net/qede/base/common_hsi.h | 6 +- >>> drivers/net/qede/base/ecore.h | 4 +- >>> drivers/net/qede/base/ecore_dev.c | 19 ++- >>> drivers/net/qede/base/ecore_hsi_debug_tools.h | 3 + >>> drivers/net/qede/base/ecore_hw.c | 4 +- >>> drivers/net/qede/base/ecore_init_fw_funcs.c | 138 >> ++++++++++++++++++ >>> drivers/net/qede/base/ecore_init_fw_funcs.h | 35 +++++ >>> drivers/net/qede/base/ecore_int.c | 14 +- >>> drivers/net/qede/base/ecore_iro_values.h | 122 ++++++++-------- >>> drivers/net/qede/qede_ethdev.h | 2 +- >>> drivers/net/qede/qede_main.c | 2 +- >>> 12 files changed, 274 insertions(+), 79 deletions(-) >>> >>> diff --git a/doc/guides/nics/qede.rst b/doc/guides/nics/qede.rst index >>> 471d98014..2f4045795 100644 >>> --- a/doc/guides/nics/qede.rst >>> +++ b/doc/guides/nics/qede.rst >>> @@ -78,9 +78,9 @@ Supported QLogic Adapters Prerequisites >>> ------------- >>> >>> -- Requires storm firmware version **8.37.7.0**. Firmware may be >>> available >>> +- Requires storm firmware version **8.40.33.0**. Firmware may be >>> +available >>> inbox in certain newer Linux distros under the standard directory >>> - ``E.g. /lib/firmware/qed/qed_init_values-8.37.7.0.bin``. >>> + ``E.g. /lib/firmware/qed/qed_init_values-8.40.33.0.bin``. >> >> Not available in latest Fedora and Ubuntu releases >=20 > That is right, it would take some time before its available in latest Fed= ora/Ubuntu releases. >> >>> If the required firmware files are not available then download it fr= om >>> `linux-firmware git repository >>> >> b_scm_linux_kernel_git_firmware_linux- >> 2Dfirmware.git_tree_qed&d=3DDwIFaQ >>> >> &c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3D9aB46H7c7TYTnBun6ODgtnNLQdw3jNiVKH >> bs9eOyBS >>> >> U&m=3DLjD8kHeZxFHw1ql6Jz5s_XJfxPOIaBqLpyP5FDBNHQc&s=3DYOhhxcxca9mX >> dFNN7HjG >>> djQF5G22nnsfj1fy4S4cOCM&e=3D >`_ >> >> Not available here either >=20 > We are working on getting 8.40.33.0 version into linux-firmware git tree. >=20 > Thanks! > -Rasesh >> >>> or `QLogic Driver Download Center >> > Search.aspx>`_. >> >> Maybe here? 8.37 is the latest elsewhere. >=20