From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wj0-f171.google.com (mail-wj0-f171.google.com [209.85.210.171]) by dpdk.org (Postfix) with ESMTP id 81E792946 for <dev@dpdk.org>; Tue, 3 Jan 2017 15:14:48 +0100 (CET) Received: by mail-wj0-f171.google.com with SMTP id c11so240943705wjx.3 for <dev@dpdk.org>; Tue, 03 Jan 2017 06:14:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=POJtVUXNwjIl4ZxpVfxSNiebWc+WruvDaVR3foj8olA=; b=QhmmU3fRT/wSHSgtVKvre+e6ABYFY/8ObU4xP9TQeRNnPPFzmqYPxuXMFpGgwlim87 uCnoHZKTm73vJaRwddX4ayaku7gGmQ26pj1HDjS6uns0oiMx3JmJbIJb4Dd9GkBoVMBu Qd5I/4rgq6jRr9FcKwmOdQGvJAERhc9XEvz6za4zSLPXK1kiN7QjbyNeWGrIimlvjyKL 0KwjG/qoH/FNSydFWomSo/A8aOw9m1B45tyXrMVCs79lf68LYgUW7n1uM2z3kJ7zy02N CICqg3dRsZ3iyjkG7eOaTCyxjih5iMfhEdG1gaLGeukNEaBAMnNgcDoip8ZHgI1uLn5Z 6D1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=POJtVUXNwjIl4ZxpVfxSNiebWc+WruvDaVR3foj8olA=; b=kZXz+btT56IdT96DmkCKo/nPzH04zMWvG7OlWQK375+NF7XJmXxC16dHujuFnUuNy2 KqEb+7ZnRHbl4ir6I7HGPvOezFiWMAyTRHpMD7iCWpC15IMGLZqADmZuMZfhH6M+BfNc lYe2Q7V1iGrb4fsBX4Y+4PDgTuflWamnJsztvymnIXtEWmdRp4my9vupmNhBFx7D7NGe zxXPWQQ3QdkqMESrWpElJABGmatMCOKnPhPYwi9BNB13CPA8iuSc0p1aQyluh4KOZsFZ 1BZznQuT7VIfsXjo4qw7fxhfyI1WeyekLKmVL66isYAjstWTRIi8P97xHqAx5rZY7SrO rIUg== X-Gm-Message-State: AIkVDXJdherFdzH0ZYdHOS7f51HMhJ4hctZ57bzgtqSDKXLDMr1Lf0TkCw0U4kvu0MHtYi15 X-Received: by 10.194.161.65 with SMTP id xq1mr53563350wjb.104.1483452888171; Tue, 03 Jan 2017 06:14:48 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id ct7sm93276750wjc.2.2017.01.03.06.14.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Jan 2017 06:14:47 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Piotr Azarewicz <piotrx.t.azarewicz@intel.com> Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com Date: Tue, 03 Jan 2017 15:14:46 +0100 Message-ID: <10528878.kOcN2Qlpj0@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1483448523-150510-1-git-send-email-piotrx.t.azarewicz@intel.com> References: <1482864823-9164-1-git-send-email-michalx.k.jastrzebski@intel.com> <1483448523-150510-1-git-send-email-piotrx.t.azarewicz@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] crypto/aesni_gcm: migration from MB library to ISA-L X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 03 Jan 2017 14:14:48 -0000 2017-01-03 14:02, Piotr Azarewicz: > Current Cryptodev AES-NI GCM PMD is implemented using Multi Buffer > Crypto library.This patch reimplement the device using ISA-L Crypto > library: https://github.com/01org/isa-l_crypto. > > The migration entailed the following additional support for: > * GMAC algorithm. > * 256-bit cipher key. > * Session-less mode. > * Out-of place processing > * Scatter-gatter support for chained mbufs (only out-of place and > destination mbuf must be contiguous) > > Verified current unit tests and added new unit tests to verify new > functionalities. > > Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com> [...] > The AES-NI GCM PMD (**librte_pmd_aesni_gcm**) provides poll mode crypto driver > -support for utilizing Intel multi buffer library (see AES-NI Multi-buffer PMD documentation > -to learn more about it, including installation). > - > -The AES-NI GCM PMD has current only been tested on Fedora 21 64-bit with gcc. > +support for utilizing Intel ISA-L crypto library, which provides operation acceleration > +through the AES-NI instruction sets for AES-GCM authenticated cipher algorithm. Please could you compare these libraries regarding the performance? [...] > Features > -------- > @@ -49,16 +47,21 @@ Cipher algorithms: > Authentication algorithms: > > * RTE_CRYPTO_AUTH_AES_GCM > +* RTE_CRYPTO_AUTH_AES_GMAC > + > +Installation > +------------ > + > +To build DPDK with the AESNI_GCM_PMD the user is required to install > +the ``libisal_crypto`` library in the build environment. > +For download and more details please visit `<https://github.com/01org/isa-l_crypto>`_. [...] > Limitations > ----------- > > -* Chained mbufs are not supported. > +* Chained mbufs are supported but only out-of-place (destination mbuf must be contiguous). > * Hash only is not supported. > * Cipher only is not supported. > -* Only in-place is currently supported (destination address is the same as source address). > -* Only supports session-oriented API implementation (session-less APIs are not supported). > * Not performance tuned. [...] > --- a/drivers/crypto/aesni_gcm/Makefile > +++ b/drivers/crypto/aesni_gcm/Makefile > @@ -31,9 +31,6 @@ > include $(RTE_SDK)/mk/rte.vars.mk > > ifneq ($(MAKECMDGOALS),clean) > -ifeq ($(AESNI_MULTI_BUFFER_LIB_PATH),) > -$(error "Please define AESNI_MULTI_BUFFER_LIB_PATH environment variable") > -endif > endif > > # library name > @@ -50,10 +47,7 @@ LIBABIVER := 1 > EXPORT_MAP := rte_pmd_aesni_gcm_version.map > > # external library dependencies > -CFLAGS += -I$(AESNI_MULTI_BUFFER_LIB_PATH) > -CFLAGS += -I$(AESNI_MULTI_BUFFER_LIB_PATH)/include > -LDLIBS += -L$(AESNI_MULTI_BUFFER_LIB_PATH) -lIPSec_MB > -LDLIBS += -lcrypto > +LDLIBS += -lisal_crypto You need to update the script test-build.sh. Thanks