From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA1ADA0353; Thu, 6 Aug 2020 18:53:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 074841BFF5; Thu, 6 Aug 2020 18:53:47 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 04FAF2C28 for ; Thu, 6 Aug 2020 18:53:44 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 7C235574; Thu, 6 Aug 2020 12:53:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 06 Aug 2020 12:53:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= sewUqbCxjpG8Eejm42JPrkvp0jyIMLBG0hxPM1MD62s=; b=WbE0TzguOYQ2kacQ hXbTImREJNRpCilZ5fBl27/Krf8OqOe+BvdGeCkPT0AWsNarQbhUxsvA6B5xfIbE /F8GuVgavkKp2vN1L0tb9XPMNLDjGFVHtJd4+RbvPLJwVQUm3t3JbNrkJJHWYcL6 jdtWHTt+kz+MV5NSHa4gw4V3s/EjH4uWt8139/JgVxgVdXxZz7W0ijffy3/FsUd4 YBZA/+CfZW70i9gsWZxYcRwvVa+hZE6CYxQE3RC2expkCjZas4XUBF42qouhAcwH jNj5pdMviIK+xhEtnV7bGa1MMaT+Lp/48UFJD3uiiB2ZwCDlTnT8VsTiyF7DU1gT Yi2Dpw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=sewUqbCxjpG8Eejm42JPrkvp0jyIMLBG0hxPM1MD6 2s=; b=elKtxxml9D63m4tlWwJktC6QHAb4IPf4Ka25d69TNrMByvVnyOl9HdSZE 5B8MEbJsdq+tx5xIwu826rdPtn2B4H9ij3eNxuzS5O9AM5YL5BeLJSB70DAGH1IQ 2H4jG/74yWZ9p6c6UEeyaOqalPeCVfrKo3wnQ4nfeXuYKPEzmtd4nyAg++Runv1G JMdTqMwPYPL9vFMq7vlajBUdST68APTIN2UVRKJ0PjfROxtjPfOOVAuiziaMtI0/ TshH/Nl81Cc//7FXY8/RmlyjwE4HG6TcLc+98jW1Ynv+0XoUF5iB5aVMi4orh4g/ vOlU+LU7KDZb28K9pP9E5Sge1HsQw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrkedtgddutdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 14223328005D; Thu, 6 Aug 2020 12:53:41 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Luca Boccassi , bruce.richardson@intel.com, arybchenko@solarflare.com, ferruh.yigit@intel.com Date: Thu, 06 Aug 2020 18:53:41 +0200 Message-ID: <10564419.82xbvLcRvO@thomas> In-Reply-To: <20200730005804.19251-6-stephen@networkplumber.org> References: <20200604210200.25405-1-stephen@networkplumber.org> <20200730005804.19251-1-stephen@networkplumber.org> <20200730005804.19251-6-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 20.08 5/6] rte_ethdev: change comment to rte_dev_eth_mac_addr_add X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/07/2020 02:58, Stephen Hemminger: > The comment used the term whitelist and was awkardly written. > Replace it with simpler direct description of adding a new address. > No code or API changes for this. > > Signed-off-by: Stephen Hemminger > Acked-by: Luca Boccassi > --- > lib/librte_ethdev/rte_ethdev.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index 57e4a6ca58fd..cde6a9645360 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -3387,8 +3387,7 @@ int rte_eth_dev_priority_flow_ctrl_set(uint16_t port_id, > struct rte_eth_pfc_conf *pfc_conf); > > /** > - * Add a MAC address to an internal array of addresses used to enable whitelist > - * filtering to accept packets only if the destination MAC address matches. > + * Add a MAC address to an set of addresses used for accepting incoming packets. I propose this wording: Add a MAC address to a set used for filtering incoming packets.