From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 2B4CAA0093;
Thu, 13 Jan 2022 18:33:00 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id A382F42746;
Thu, 13 Jan 2022 18:32:59 +0100 (CET)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
[66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id AAEC140150;
Thu, 13 Jan 2022 18:32:58 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
by mailout.nyi.internal (Postfix) with ESMTP id 4C8F05C0126;
Thu, 13 Jan 2022 12:32:56 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
by compute2.internal (MEProxy); Thu, 13 Jan 2022 12:32:56 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm3; bh=
a2PcdJK7yVT7O8RMQ97f0lEnYvdxH8Aosw3IwznpK98=; b=gjsQ30/toBOQs6ZI
jWA4ZpV6aRxESvHQXU9ya5QTmfcG9KKjibzjW0DTCVelzZLGewpFl6YrSg7sp0ZI
fPulFDUjyY64rnVvepAqTqeaJLX+UsQfGHFJR8zaopMrHPri4CD9vDqi6c0JZnYR
GhDTe//VeAVVIDzG1q4aU/0KZlK3gCH916hzd6J0TqD1OMCHEJE9aIV7b1wCnFQ0
+40x62yvLtA53kDlXu6/KrEmrTaEJFQnGFuhr+kt9395bcoE9ByuI1dZ0AMjD3cX
+evxy/p8dGscpn3ia8HHgVGUAQ46gSJ81PQoBxX4aoSzFnSxscBA7QEs47Weq9XK
BJnU1Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=a2PcdJK7yVT7O8RMQ97f0lEnYvdxH8Aosw3IwznpK
98=; b=kjJGjIyEBjFK9Odcle1WthehVNv5fr9mDXCRk/QgIk5XhCcLdTchVvRPW
xCjjbq9vx/5NBkExGUpKdusBK5NXg3VrkP+jw3xbxnbepbQYlX5d9YWGpen5YyFU
CID/G+vgq2WLHICbyACOVmV1cnBI6PsPxhR+2UCfPwP0moOXuWXQRejkqgUzleWX
IU26VCEE8PikiGOaKqMpBG6EFlltnlfF1VNVrlSAyblmGI2bC76LShek7+Oyk54u
1829Mu4yMiD/KKW9s68Di3N1BxXnpZkC0Sx1n66RUHLDHBchBIhGTTP9GyOLL0oj
glpmpJWYzzgqoPTvU+HcncwNIGV0Q==
X-ME-Sender: <xms:R2LgYetSW8OXk6mVlO2NhPElGvTZeN5uG2d3-j22-zbwSzL39QTtiA>
<xme:R2LgYTeM-7yAHXjQJZjufnG43X5aFR4Qph1f20cVOFzDjBFBWRwM-_-QpO1DyfEWK
4kZ6638kfBsW67lvQ>
X-ME-Received: <xmr:R2LgYZx1KGNDvykJsa14FvyOIHizWJMRKEuO32InHwXvuq80ksB7Deg_ErfgO7ZoqJmIMbytOfHOYWbIUTvd9r_9QQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrtdefgddutddvucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:R2LgYZOnl4rTPQpTgDEDG5KEfj1ifEm_UXRaHt4HNfJ4_pizX0vNeQ>
<xmx:R2LgYe8v6HQ4QOCJu3vK124fLzoAmhnLy-nb9Dg8ojLw-NHljJy_HQ>
<xmx:R2LgYRW_J1UM08gB2MqouYK8qx61nOtJdl5MhstjiPvaJB33FfoKHg>
<xmx:SGLgYTOSTA7fAQVDovpqJi4wnq6R_1pl919tUGLtJlgt4OqNTABFQA>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
13 Jan 2022 12:32:54 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ruifeng Wang <ruifeng.wang@arm.com>
Cc: dev@dpdk.org, stable@dpdk.org, viktorin@rehivetech.com,
bruce.richardson@intel.com, stephen@networkplumber.org,
juraj.linkes@pantheon.tech, honnappa.nagarahalli@arm.com, nd@arm.com
Subject: Re: [PATCH] build: add missing arch define for Arm
Date: Thu, 13 Jan 2022 18:32:52 +0100
Message-ID: <10596176.5MRjnR8RnV@thomas>
In-Reply-To: <20211217085430.820773-1-ruifeng.wang@arm.com>
References: <20211217085430.820773-1-ruifeng.wang@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
17/12/2021 09:54, Ruifeng Wang:
> As per design document, RTE_ARCH is the name of the architecture.
> However, the definition was missing on Arm with meson build.
> It impacts applications that refers to this string.
>
> Added for Arm builds.
>
> Fixes: b1d48c41189a ("build: support ARM with meson")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
> ['RTE_ARCH_ARMv8_AARCH32', true],
> + ['RTE_ARCH', 'arm64_aarch32'],
Why not armv8_aarch32?
[...]
> dpdk_conf.set('RTE_ARCH_ARMv7', true)
> + dpdk_conf.set('RTE_ARCH', 'armv7')
[...]
> # armv8 build
> + dpdk_conf.set('RTE_ARCH', 'arm64')
Why not armv8?
What I prefer the most in silicon industry is the naming craziness :)