From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF80B42B98; Thu, 25 May 2023 10:38:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 852E040DDB; Thu, 25 May 2023 10:38:31 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id EC56140A82 for ; Thu, 25 May 2023 10:38:29 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 744053200950; Thu, 25 May 2023 04:38:27 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 25 May 2023 04:38:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1685003907; x=1685090307; bh=5bafy9uNgNT2pGurstNvAykiusfd9UeKLqh VvN8o7es=; b=YizRdKAL+Ezfde6JvVeBvLB2wN04y+rQpin9QyUz4dLcs8MdzNd p+5Tpmbp0g+MpA1SMYolqHuxcUoq9IviX59wC7uJYI/vjbJNqEqEFmD7CGq2HqGs 3lz9OswtXm15arbFoU8MCCFG9DImTMxw1QEhOi/EHCvTGcQ5nYS0ucU2guNEagxn EqZomdJp7YUs4aAhEqrY33UB7aM+aKIkehnQMugtqtDyISugt7DjdzPqRc57bpSv E6HBSnXt2HmdNmmpzQRdRkDSB1xUwVIX5P0hjNS5qOch5QC8sZU51hGEVNvh+GLO sxPgkjT+Fga63EszH4auzV4lm9+wrzAha2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1685003907; x=1685090307; bh=5bafy9uNgNT2pGurstNvAykiusfd9UeKLqh VvN8o7es=; b=uNsrFBDHVO4AHBP1QFBB2HJW3n1RD4RcivpbplDsscfa0ZkFwIH PdLme91Hz/gVXEucrOY1vTI80rJ/OWS85f9OYVVsu0Fp2K6VGuHAgtYjnKeq+CJZ GiUm2JWyfmfiTPDE+gS663RtPomZ40mkLsh5B3+VJi/kxL2Q2LBB+B5+AJ4/Ee2f /qF9ky0eXwdK9Ag4xAy2z+cTwjF8ccdNRUSjEbu/un/YmbM7KEY5M5kKJhO+EbqJ /n31DYvdB2d15Qm7vAcssjskFWrwt3ykjrKvx/H+ibdczvdAmCCefJrZ3oWf9ieC 4V0oE5R6XOLdTzidHdjm/fjmLlUDDka6OFQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejjedgtdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 25 May 2023 04:38:25 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, Ciara Power , Tyler Retzlaff , Bruce Richardson Subject: Re: [PATCH] telemetry: fix JSON string formatter Date: Thu, 25 May 2023 10:38:23 +0200 Message-ID: <10600093.aFP6jjVeTY@thomas> In-Reply-To: References: <20230525072035.2512566-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 25/05/2023 10:30, Bruce Richardson: > On Thu, May 25, 2023 at 09:20:35AM +0200, David Marchand wrote: > > For large strings, we were incorrectly copying uninitialised data to the > > output buffer. > > Restore previous code. > > > > Fixes: a515b7204e28 ("telemetry: remove VLA in JSON string formatter") > > > > Signed-off-by: David Marchand > > --- > Acked-by: Bruce Richardson Applied, thanks (and sorry for merging the commit triggering CI failures).