From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 339701B3E9; Wed, 9 May 2018 15:43:34 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7FF86224AA; Wed, 9 May 2018 09:43:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 09 May 2018 09:43:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=beSFFSnIO4b1xSnIeb8pfaKj1A LeQPz1NzfEDqkAbCY=; b=dUuxjli5gSmHt9UsMYvHH2urzoqr2//cRj4kyJy/Aq b5mrOP6q4ME66DfcbAwRNW6xFsx0RguRxHKmZR4GZu/yVeGM6VI4V5yHBFZ/sZqw 8nrtdQ8KVxhd3o6XwzaqThpeQcqrWgJG9OgSEDGbGIWpwb+8b+Cb43A8bxTg8L9q U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=beSFFS nIO4b1xSnIeb8pfaKj1ALeQPz1NzfEDqkAbCY=; b=lKw+WGTSN3ModIo/bvF7GE 9ML7vsteqBiLekbmuIQGrzx/II2oZnpkaj97duxZEaBOGIVffq2lq12RoEqgEX7O Eu+Btm2ndsWdCH44cA2hcPFfnX2RiAbGSGSbqBWgQr2XE0uFunt6G/JLZgbb+eZv PSUOfCYybpVgYDkTRpwHy3eFxgAwjghOAAFlJaTnMmhTcQPNzEpA69Ik8+D58I0W M3eblAjrJt/lb7IgDKplKCvUCjAbTtilugn8R3ZSx8zBz0c1h3WmLgoJK2RV3GkR cbcqU7QNeVR+BBkAKfn1b2cwRjVy0Wl/y68SLPRbDlcn5PXpq9h4tRHaDtwfXBxA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B1810E5082; Wed, 9 May 2018 09:43:32 -0400 (EDT) From: Thomas Monjalon To: =?ISO-8859-1?Q?Ga=EBtan?= Rivet Cc: Matan Azrad , "dev@dpdk.org" , "stable@dpdk.org" Date: Wed, 09 May 2018 15:43:31 +0200 Message-ID: <10613870.Sdbp1i1ck2@xps> In-Reply-To: <20180509133013.yxy66njakty2g7y2@bidouze.vm.6wind.com> References: <20180509094337.26112-1-thomas@monjalon.net> <20180509133013.yxy66njakty2g7y2@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH 10/11] net/failsafe: fix sub-device ownership race X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 13:43:34 -0000 09/05/2018 15:30, Ga=EBtan Rivet: > On Wed, May 09, 2018 at 01:01:58PM +0000, Matan Azrad wrote: > > Hi Gaetan > >=20 > > Regarding backporting. > > This version should be bacported for 18.02.1. > > There we have the new event. > >=20 >=20 > Then the fixline should probably reflect this instead. > Targetting the initial failsafe release won't work. >=20 > This patch also relies on probing_finish() being introduced, so I guess > the plan is to backport the whole series in 18.02.1? Yes, I will provide a backported series for 18.02. =20 > If so, I think the whole series should target the same commit id within > this release, maybe the introduction of ownership or RTE_ETH_EVENT_NEW. >=20 > In any case, I think I recall being told to leave this to stable > maintainers to deal with. However, I do not see the benefit of having > a fixline if the information is meant to be discarded for someone to do > the work again. The information in the Fixes line shows where the bug was introduced. It is used to do our backports (to know if a fix is relevant) but it can be used for other purposes like identifying known issues in a given version. So, in short, these bugs can be fixed easily in 18.02, but probably not worth to backport in older releases (no 17.11 backport). > > Regarding uint32 > > The maximum port id number can be 0xffff. > > In this case the loop will be infinite if we use uint16 to iterate over= all the ports. >=20 > If RTE_MAX_ETHPORTS is set to 0xffff, an array rte_eth_devices[0xffff] > would be defined statically, and I think other issues would arise > before our being stuck in an infinite loop? >=20 > In any case, if this had to be fixed, then there should be a > BUILD_BUG_ON RTE_MAX_ETHPORTS being 0xffff, in the relevant part of > librte_ethdev, instead of relying on librte_ethdev users skirting > shortfalls of the library. Anyone iterating on port IDs should expect the > port_id type to be sufficient to hold this information. Interesting thought. I vote for keeping Matan's option as it is correct, and will accept a patch in 18.08 for your option (BUILD_BUG_ON). Maybe we should send a deprecation notice before limiting the max number of ports to 0xfffe? Or is it ridiculous for such unlikely constraint= ?