From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id 27AE9E72
 for <dev@dpdk.org>; Fri, 12 Jun 2015 11:14:51 +0200 (CEST)
Received: by wgme6 with SMTP id e6so20108973wgm.2
 for <dev@dpdk.org>; Fri, 12 Jun 2015 02:14:51 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=QF1k6iwqgb0oD3zRDE2z2jsSxbqA0FL4m0TE+Mihrxg=;
 b=BLL7oGtZ+XCTwO23TnAoWP5rHcCwN/adqqf8f8Rc/RHFCVRZ58BGSMay2Tf5l0Gjmr
 EFmXM9qvxW20wi8Nd98O/tBHzIw1R8GsgsF+D/MisS7e8eugkFl2y1u3aKUDNzB5kRlG
 ASiuM7RU3P3WaSh5u9OxL6N4JeKm+6hFiY7qqZEIceyl+jxc1Q0/dFMdy7DNHvoLnZP2
 ka7NPQYEmmfCsmyj25THf9XZ0IXgXUJI6pAWahW7oOZK/A5HhSfHUvUzT0pEeaiU1i3+
 +7Z911PBjLwGx6cT39qrulTH6GSaMPxL5h3Jd+2n/W9VsqHYQMPmKi1wzOi/yfuEEoKE
 p7Tw==
X-Gm-Message-State: ALoCoQlyBcSdODSXFaygdcnHTU/owTUoQ/M6DzaTGvcmb4x04/EtszujSZCx476PcmiiFvQ1zaCJ
X-Received: by 10.194.237.34 with SMTP id uz2mr25024912wjc.155.1434100491041; 
 Fri, 12 Jun 2015 02:14:51 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id s10sm4885012wjy.35.2015.06.12.02.14.49
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 12 Jun 2015 02:14:49 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 12 Jun 2015 11:13:52 +0200
Message-ID: <10636183.XYdRXAllQb@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1432914471-20061-1-git-send-email-stephen@networkplumber.org>
References: <1432914471-20061-1-git-send-email-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] pmd: change initialization to indicate pci
	drivers
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Jun 2015 09:14:51 -0000

2015-05-29 08:47, Stephen Hemminger:
> Upcoming drivers will need to be able to support other bus types.
> This is a transparent change to how struct eth_driver is initialized.
> It has not function or ABI layout impact, but makes adding a later
> bus type (Xen, Hyper-V, ...) much easier.
> 
> Signed-off-by: Stpehen Hemminger <stephen@networkplumber.org>

There is a (fixed) typo in this line. Please use --signoff.

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied, thanks

Next step would be to avoid this strange assumption:
struct eth_driver {
    struct rte_pci_driver pci_drv;    /**< The PMD is also a PCI driver. */