From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FC72A0032; Wed, 11 May 2022 16:50:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3BE8040DDD; Wed, 11 May 2022 16:50:55 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id F0ABA406B4; Wed, 11 May 2022 16:50:53 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id E7F8932009BA; Wed, 11 May 2022 10:50:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 11 May 2022 10:50:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1652280650; x= 1652367050; bh=x4plHRtH18S3a5KCFR85wpInoHb37l1XwWkTpKAPaUQ=; b=a oDj5ksG60WNBLd+0LI9mRq9+1BhowkNC7WkXkYMHW0LR6J3FT3dxP9tR8FKxsfoa QCc8kuBenCz6o0yatCGh4E+AAfLWyYqw7UePYZxeRWKqrORei/gPcWV1E/wFQG/S OH1u2kOTgqVeeri/Bn8X4fNf4gVSp2AKUKb/4Y0eibf0K9PqqDYVArr2e/gqOMvc 0MSmjEnwMG8hUJT/oPiBQYCSbEUGMB4dqFFAGlopsZ/lzTInQ6doXSKZK0c/Jc/N DTRYNs6yVGDeBXQCOHcrQD1IQ4tdqGHiGGQSerQREMfBZwHiHDxSY1vrFiCaJF5k SNapD+I08u0yIw64a2uVA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1652280650; x=1652367050; bh=x4plHRtH18S3a 5KCFR85wpInoHb37l1XwWkTpKAPaUQ=; b=C6zxwzhT1+aKw+PbO3qW5hQceQtKg 29xAASe95k+q2qTLilDBdjW5T0Nci3YLqsqT5J5cnSHQK3lRzgvO4/dEChA6gjlU 3AqEW8FpdR/mIFUnoHC/ughAj4qK59QZA8lVRa+QxO1y+ivH/dRWabaNX0lE3Oa7 rjsc8x/zzmdfEhDktz3P4mV6JPwRf30ydQqKykN0Q8r9/mNIiKXrgNWDzGJEavn4 hWS0ckAtUfUk28v4qL0wVjM/k4uYvaM1ZXlHXXajniuqlSEa1y1NoWQsQXBD5Ovq WwwexnQTQRwZ0AFqvRpDsYn22nOIh8wMQ0jqaschkfBN51WMv+Rhe3p8w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgeehgdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 11 May 2022 10:50:48 -0400 (EDT) From: Thomas Monjalon To: Jeff Daly , "Zhang, Qi Z" Cc: "Yang, Qiming" , "Wu, Wenjun1" , "Zhao1, Wei" , Xiao Zhang , Xiaolong Ye , Lunyuan Cui , dev@dpdk.org, "stable@dpdk.org" Subject: Re: [PATCH] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices Date: Wed, 11 May 2022 16:50:47 +0200 Message-ID: <10661272.5MRjnR8RnV@thomas> In-Reply-To: <36a68dda846440738e43d83a105b358c@intel.com> References: <20220510185725.27001-1-jeffd@silicom-usa.com> <36a68dda846440738e43d83a105b358c@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 11/05/2022 13:43, Zhang, Qi Z: > From: Jeff Daly > > > > 1ca05831b9b added a check that SDP3 (used as a TX_DISABLE output to the SFP > > cage on these cards) is not asserted to avoid incorrectly reporting link up when > > the SFP's laser is turned off. > > > > ff8162cb957 limited this workaround to fiber ports > > > > This patch: > > * Adds devarg 'fiber_sdp3_no_tx_disable' not all fiber ixgbe devs use > > SDP3 as TX_DISABLE > > > > Fixes: 1ca05831b9b ("net/ixgbe: fix link status") > > Fixes: ff8162cb957 ("net/ixgbe: fix link status") > > Cc: stable@dpdk.org > > > > Signed-off-by: Jeff Daly > > Acked-by: Qi Zhang > > Applied to dpdk-next-net-intel. There is a lack of context in this description. I don't know what SDP3 and TX_DISABLE refers to. Please make more complete sentences, thanks.