From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31348A0A0C; Thu, 22 Jul 2021 18:12:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A718C4014D; Thu, 22 Jul 2021 18:12:38 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 1232140040 for ; Thu, 22 Jul 2021 18:12:37 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id AFB5E32008C0; Thu, 22 Jul 2021 12:12:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 22 Jul 2021 12:12:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= RMXCti2LhMRy/ax3i4DcQqb0bTKiaiF8QZ3GlyLgvrA=; b=YhOEFPlLs2+s3BQG GM3dAlR+aYh46sBnUg1/bMyi6N+0uKspSFFFDaSm41pQMNbHGsVqnBN90J+90TFY W1Dr2GEr2bzLAIiA75+gKxlpNMVM+j+OubSUStXGC7GG36ChrvtDvlzLdqR6sDjm cnq1S37c+WDo7ZfCug0//Ar24iZOUAhUyUlOSAw/J8Ofvv8XkjkOlTyy2OyIxZqW 390Jqz6sA3eJ0rdS0xIoCS2YHqlqhpSu4hmE9PdzOJR/u0pr/2ct0BetmB512LvN dT7/0xGnAzTpvZZW1WYyCGrrJG2f0EOv8cnHeUWLa+UPelr7oVZx3CUUmLCgKdyT JloUbw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=RMXCti2LhMRy/ax3i4DcQqb0bTKiaiF8QZ3GlyLgv rA=; b=WgKlNOZN0A4dyVuEAb5sZhp2rDCAH1EUZOSxw7uzEboiVnOIxSEedZoH5 h2P9lSpyCWTct2Dvbbk2dEldel4LWSopnqS25MryOxZSk/yR0g3elsNC7GIsEAJi STtSWH+BQV45eCwExYpgM9vs0xR6ZqvPz3nuMZ6YRhlFrauhc0w6Y51ts6NqhtEn 0iuOVtXknThYA0aIOlwsOaj0NyuIcEZwQXtvCVNuZ+rahrXOiyA102cW38qVANh+ ub5csyeoSh75pRPOx6ieF8eTTkPCJ5cr7ZDLpb0etqsb1WRldIEV22hCDJPVI6Qb /zSDQeH1zRYsa6jUcO4XH0LOQl37g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeeigdelvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Jul 2021 12:12:32 -0400 (EDT) From: Thomas Monjalon To: "Jiang, Cheng1" , "Xia, Chenbo" Cc: "maxime.coquelin@redhat.com" , dev@dpdk.org, "Hu, Jiayu" , "Yang, YvonneX" , david.marchand@redhat.com Date: Thu, 22 Jul 2021 18:12:51 +0200 Message-ID: <10705747.pk50nUbaNJ@thomas> In-Reply-To: References: <20210602042802.31943-1-cheng1.jiang@intel.com> <20210722040907.20468-1-cheng1.jiang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 0/5] vhost: handle memory hotplug for async vhost X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/07/2021 07:07, Xia, Chenbo: > From: Jiang, Cheng1 > > When the guest memory is hotplugged, the vhost application which > > enables DMA acceleration must stop DMA transfers before the vhost > > re-maps the guest memory. > > > > This patch set is to provide an unsafe API to drain inflight pkts > > which are submitted to DMA engine in vhost async data path, and > > notify the vhost application of stopping DMA transfers. And enable it > > in vhost example. > > Series applied to next-virtio/main. Thanks I cannot pull this series in main branch. There is a compilation error seen on Arm cross-compilation: examples/vhost/main.c:1493:51: error: assignment to 'int32_t (*)(int, uint16_t, struct rte_vhost_async_desc *, struct rte_vhost_async_status *, uint16_t)' {aka 'int (*)(int, short unsigned int, struct rte_vhost_async_desc *, struct rte_vhost_async_status *, short unsigned int)'} from incompatible pointer type 'uint32_t (*)(int, uint16_t, struct rte_vhost_async_desc *, struct rte_vhost_async_status *, uint16_t)' {aka 'unsigned int (*)(int, short unsigned int, struct rte_vhost_async_desc *, struct rte_vhost_async_status *, short unsigned int)'} [-Werror=incompatible-pointer-types] 1493 | channel_ops.transfer_data = ioat_transfer_data_cb; | ^ Other comments about the last patch: - it is updating doc out of the original patch doing the code changes - there is not even a reference to the code patch (Fixes: line) - the addition in the release notes is not sorted Last question while at it, why having the API documentation in the vhost guide (rst file)? Doxygen is not enough to describe the functions?