From: Thomas Monjalon <thomas@monjalon.net>
To: Pallavi Kadam <pallavi.kadam@intel.com>
Cc: dev@dpdk.org, ranjit.menon@intel.com, talshn@mellanox.com,
pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com,
narcisa.vasile@microsoft.com
Subject: Re: [dpdk-dev] [PATCH 2/2] build: add module definitions and pci lib support
Date: Tue, 17 Mar 2020 10:31:34 +0100 [thread overview]
Message-ID: <10706758.F0gNSz5aLb@xps> (raw)
In-Reply-To: <20200317004802.11424-3-pallavi.kadam@intel.com>
17/03/2020 01:48, Pallavi Kadam:
> Added mman functions to eal exports list.
[...]
> --- a/lib/librte_eal/rte_eal_exports.def
> +++ b/lib/librte_eal/rte_eal_exports.def
This file is generated. Only the .map can be updated.
> @@ -7,3 +7,5 @@ EXPORTS
> rte_eal_remote_launch
> rte_log
> rte_vlog
> + mmap
> + munmap
These functions should not be exported for Linux.
And in general, I think it would be better to state what is
the memory management strategy on Windows first.
Maybe we will need to use a different abstraction.
next prev parent reply other threads:[~2020-03-17 9:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 0:48 [dpdk-dev] [PATCH 0/2] Support librte_pci on Windows Pallavi Kadam
2020-03-17 0:48 ` [dpdk-dev] [PATCH 1/2] eal: mman implementation for windows Pallavi Kadam
2020-03-17 0:48 ` [dpdk-dev] [PATCH 2/2] build: add module definitions and pci lib support Pallavi Kadam
2020-03-17 9:31 ` Thomas Monjalon [this message]
2020-03-18 0:28 ` Dmitry Kozlyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10706758.F0gNSz5aLb@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=narcisa.vasile@microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).