From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D962FA0A0E; Wed, 3 Feb 2021 13:54:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E6B0240589; Wed, 3 Feb 2021 13:54:07 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 38A17240578 for ; Wed, 3 Feb 2021 13:54:05 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id DC142340; Wed, 3 Feb 2021 07:54:02 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 03 Feb 2021 07:54:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= H/Ptsm/70JJiVBzBd0xeDVigvPc2Ln4r7qCw3zqTJzM=; b=F+7fwW7Jqt5m1sRX qT2YjiV2+5aC5BHowL96qv2lkhooL39VTeJlx28+7K7bqrl63vdjvbmoc/HGOaAn FmoaTzpg/jF1mZKxyCzPlvhAKRFC4/ckorBIN2ff66Y+t1zZZimZEAd5oy8lVDu/ y2C9tfG+R7I1iagPany3OG8R9saJrp94YNPFREI/NhGKJm2Ivf0M4wpoRFA4uebB jckXp2/8A2I7I9MTzDIyDuW40j/AlTjMwIxjEBhHgmRXkJasinrPXHN6MA13nqPk eReSxvLKmh6qhkvsgwM5z8w66NmTlxLaL2GSxBh2zLqu+Cst4230X8FXtNJS98Fo vwdfbg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=H/Ptsm/70JJiVBzBd0xeDVigvPc2Ln4r7qCw3zqTJ zM=; b=oL0UV5I1ffo76G55Srlphs2Czi4mG0rV0Wmxl4pmm5KeD1t+W5dpVQFUv VWqmVL8aRTP68HM41hd4V7uvttsdUcCVUufpyx68oI5nld6Lp/Z/mEkrzsB+YejH nQIq+ikjv/XHwig8PwdSqsV8cNUReIZLY//bBlT4ZGdPLAeaLoGf3fzvX/feWuwt AypqDxCMSWCtg73xP/z1y81Gbl/6rnYakN1AtnMpjPX96GDlN5fvUxbw5mI9y/sr pNHYjsULTTgPnAcuHquxhX0nM++2lLv3yIrGun75VHlunZu9tmLAxGZ6z6v1vqu0 X4TTe1lw9Pfz2yMPvEQ6APTZ2CPHg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrgedvgdeggecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeegvdehhfevkeffgeekhfdtfeevfeejkeeugfevfeejfefhjedttefh veefteefjeenucffohhmrghinhepghhithhhuhgsuhhsvghrtghonhhtvghnthdrtghomh dpghhithhhuhgsrdgtohhmnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmh honhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 949F0240065; Wed, 3 Feb 2021 07:54:01 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org Date: Wed, 03 Feb 2021 13:53:58 +0100 Message-ID: <107491602.YXUHrCGqlC@thomas> In-Reply-To: <20210203121812.GA1708@bricha3-MOBL.ger.corp.intel.com> References: <20210203103057.2821352-1-thomas@monjalon.net> <20210203121812.GA1708@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/1] doc: explain steps for improved code spell checking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/02/2021 13:18, Bruce Richardson: > On Wed, Feb 03, 2021 at 11:30:57AM +0100, Thomas Monjalon wrote: > > - https://raw.githubusercontent.com/codespell-project/codespell/master/codespell_lib/data/dictionary.txt > > + git clone https://github.com/codespell-project/codespell.git > > > > Does installing via apt or dnf work as well? If we do install from package > do we still need to specify the path to codespell as script parameter? It depends whether all needed dictionary files are installed. Are they? > > -The path to the downloaded ``dictionary.txt`` must be set > > +There is a DPDK script to build an adjusted dictionary:: > > + > > + devtools/build-dict.sh codespell/ > codespell-dpdk.txt > > + > > Do we always need to have people build this themselves? Can we create a > .codespell-dpdk.txt file in the repo and have that as the default value for > the path if the environment variable is not set? The dictionaries are frequently updated. I don't really want to update them in DPDK. The default dictionary from the distro is used by default (if installed). In general, I think only tree maintainers and CI admins have to install the dictionaries for better result.