From: Thomas Monjalon <thomas@monjalon.net>
To: Mingjin Ye <mingjinx.ye@intel.com>
Cc: dev@dpdk.org, qiming.yang@intel.com, yidingx.zhou@intel.com,
stable@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>
Subject: Re: [PATCH] bus/vdev: fix devargs memory leak
Date: Wed, 06 Mar 2024 15:01:31 +0100 [thread overview]
Message-ID: <10756368.zapYfy813O@thomas> (raw)
In-Reply-To: <20230901072409.741847-1-mingjinx.ye@intel.com>
01/09/2023 09:24, Mingjin Ye:
> When a device is created by a secondary process, an empty devargs is
> temporarily generated and bound to it. This causes the device to not
> be associated with the correct devargs, and the empty devargs are not
> released when the resource is freed.
>
> This patch fixes the issue by matching the devargs when inserting a
> device in secondary process.
>
> Fixes: dda987315ca2 ("vdev: make virtual bus use its device struct")
> Fixes: a16040453968 ("eal: extract vdev infra")
> Cc: stable@dpdk.org
>
> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> ---
> +static struct rte_devargs *
> +vdev_devargs_lookup(const char *name)
> +{
> + struct rte_devargs *devargs;
> + char dev_name[32];
> +
> + RTE_EAL_DEVARGS_FOREACH("vdev", devargs) {
> + devargs->bus->parse(devargs->name, &dev_name);
> + if (strcmp(dev_name, name) == 0) {
> + VDEV_LOG(INFO, "**Devargs matched %s", dev_name);
The beginning of the log does not need such attention characters.
Removing while merging.
With Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks.
prev parent reply other threads:[~2024-03-06 14:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 7:24 Mingjin Ye
2023-09-12 9:07 ` Ling, WeiX
2023-09-15 8:56 ` Ye, MingjinX
2023-11-07 6:56 ` Ye, MingjinX
2023-11-17 10:29 ` Ye, MingjinX
2023-12-05 10:32 ` Ye, MingjinX
2024-02-02 14:52 ` Burakov, Anatoly
2024-03-06 14:01 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10756368.zapYfy813O@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=mingjinx.ye@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=yidingx.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).