From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD5EFA0546; Thu, 16 Jul 2020 16:32:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 15ADE1BF8E; Thu, 16 Jul 2020 16:32:54 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id F28BB1BF8D for ; Thu, 16 Jul 2020 16:32:52 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 3B4D1679; Thu, 16 Jul 2020 10:32:51 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 16 Jul 2020 10:32:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= utMPehJPbWOuGlKoMdzWnN1nxpZcHbH8/wK3iaNOk8c=; b=SGbVPpHJeTsKKNWX zrVY6uilIB8aB8+lgyKHlkB0De7v1KZZgWjV6ubIBnny8Emrc5PNPSdSRkOgdJu4 D1qiWGZPSlvbb5sCCkNodJpvSm/0s72xSN5AP6yRJdKdYKiskXRijlg1sb3qkcaw aRzGVkrUj0Rd2lETc7KvBIdvXrK/IIHizzgQDtKocZDwRRihdTGpvPHzxxl/PbKf Wry16krdwn5ACIJROCEVHS2a6kyFErx+/mjKtpOSMuSVJTidMGUppFClE3WgMNtv 7N7hZax658K7C8RmlLs5iZ8uYjPU0/ha+f6ulEStyPhEKBBfkDNLzPmUArqjrRT3 9bVJMQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=utMPehJPbWOuGlKoMdzWnN1nxpZcHbH8/wK3iaNOk 8c=; b=dZbg7c61Z4a1fZeRSfye8na6w1rzleNihes30GZ8xepu63rQToapxjDRP gB0RIhTJ75tXLlty/zOP89RjgrzTt+WgEZxi380BsqXjaa4qtgRtx9AiTXvlzZUP 88Eg47TjwnitESJdcbbyMeCT6cCbzBAmPF7bK/NfRq1BH+Z8D6qA+Yez88Pm7MrL WaQIbdjcKdEdZnqs8f/f3bQuAEseJxWZ39yG02Ryz9BIwupxxK9XIeO4TkRBJ3VD l8c30bbK04cYpu+YiC/upR074uSoghAK4uoeqrgIXQRlw5p0fBC9GKjNOl3Le/jb sHi5ke8DZ9FNj0n9G3nK1MAF8D9BQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrfeeggdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5BEF4328005A; Thu, 16 Jul 2020 10:32:49 -0400 (EDT) From: Thomas Monjalon To: Vladimir Medvedkin Cc: dev@dpdk.org, david.marchand@redhat.com, jerinj@marvell.com, mdr@ashroe.eu, konstantin.ananyev@intel.com, bruce.richardson@intel.com Date: Thu, 16 Jul 2020 16:32:48 +0200 Message-ID: <10778727.YoOYBErh3j@thomas> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 2/8] fib: make lookup function type configurable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/07/2020 13:56, Vladimir Medvedkin: > Add type argument to dir24_8_get_lookup_fn() > Now it supports 3 different lookup implementations: > RTE_FIB_DIR24_8_SCALAR_MACRO > RTE_FIB_DIR24_8_SCALAR_INLINE > RTE_FIB_DIR24_8_SCALAR_UNI > > Add new rte_fib_set_lookup_fn() - user can change lookup > function type runtime. > > Signed-off-by: Vladimir Medvedkin [...] > --- a/lib/librte_fib/rte_fib.h > +++ b/lib/librte_fib/rte_fib.h > +enum rte_fib_dir24_8_lookup_type { > + RTE_FIB_DIR24_8_SCALAR_MACRO, > + RTE_FIB_DIR24_8_SCALAR_INLINE, > + RTE_FIB_DIR24_8_SCALAR_UNI > +}; Doxygen missing. [...] > +/** > + * Set lookup function based on type > + * > + * @param fib > + * FIB object handle > + * @param type > + * type of lookup function > + * > + * @return > + * -EINVAL on failure > + * 0 on success > + */ > +__rte_experimental > +int > +rte_fib_set_lookup_fn(struct rte_fib *fib, > + enum rte_fib_dir24_8_lookup_type type); I think the types deserve to be documented, explaining why using one or the other.