From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67C73A00E6 for ; Thu, 11 Jul 2019 11:29:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 05B0A4C8E; Thu, 11 Jul 2019 11:29:31 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id C801F3772 for ; Thu, 11 Jul 2019 11:29:29 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id C0056482; Thu, 11 Jul 2019 05:29:28 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 11 Jul 2019 05:29:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=lFMUqB1Wz/Zd5dCSPtH4+h8MItUlPNWbTkmRiGOXgZk=; b=Z4t8a0kgRrQy jYhN1K0nuVSVYBlWQeV89m4p0u82kxFCwFp+8xGysXYa7BPOY4LGdzg9C08VTbJ8 uk0KNwQRpcC2uKtfKTkP6XOtZgvG8GJOMMdXOKmg5FbFB62fZujUE+OjTgvSGDNw ZHosIGX9tfYBJ8JVNkYi1tx7qDUF91k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=lFMUqB1Wz/Zd5dCSPtH4+h8MItUlPNWbTkmRiGOXg Zk=; b=CYASoUA6Vq1uC83K9VaAIJsqRmWfmDqtlz6eYWBnGZHwXsIOt562RobnM gaSHVFR82kphh05nIPdzdPNWkpqpinwqtyaqHb5QgLfrLvMG9zG724VHm3WlTZhd dVjwWbSKAFnkxOX6yRR5xZdbx4nIzHuczxDsjSfEGma9V1IuntKnv9IfrPIJf6ri Bfdh0O8HrcrL5o+67bXewqYzkCvwVVA/QBa+G8Ue2zwiv1BGD8CxCI+QxqRv74Lb RHvTLzWFiTz5bkKLu21E5BHKi8j8COenZU8GqK+6DZe/laBsDiENFrnhawtGXAR0 CLNyHWi2wMxnvRMFwD871wdpvAyAA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrgeekgddujecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D06E88005C; Thu, 11 Jul 2019 05:29:26 -0400 (EDT) From: Thomas Monjalon To: Takeshi Yoshimura Cc: dev@dpdk.org, "Burakov, Anatoly" , David Christensen Date: Thu, 11 Jul 2019 11:29:25 +0200 Message-ID: <10800802.d3FvYLXJeP@xps> In-Reply-To: <5ea05b05-8054-6c9b-af73-d8bc106aa5af@intel.com> References: <20190711022235.2958-1-tyos@jp.ibm.com> <5ea05b05-8054-6c9b-af73-d8bc106aa5af@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] vfio: fix build errors on old Linux X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11/07/2019 11:17, Burakov, Anatoly: > On 11-Jul-19 3:22 AM, Takeshi Yoshimura wrote: > > The commit db90b4969e2e ("vfio: retry creating sPAPR DMA window") > > introduced a build breakage on old Linux. Linux <4.2 does not define ddw in > > struct vfio_iommu_spapr_tce_info. Without ddw, we cannot change window size > > and so should give up the creation. I just exculuded the retrying code if > > ddw is not supported. > > > > Fixes: db90b4969e2e ("vfio: retry creating sPAPR DMA window") > > > > Signed-off-by: Takeshi Yoshimura > > Tested-by: Anatoly Burakov Applied, thanks