From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAC57A0547; Wed, 19 May 2021 09:56:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B3D9410DD; Wed, 19 May 2021 09:56:15 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by mails.dpdk.org (Postfix) with ESMTP id 8540440041; Wed, 19 May 2021 09:56:14 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id E88F8580D9B; Wed, 19 May 2021 03:56:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 19 May 2021 03:56:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= sltyfScQEcv4ynVkeMQEENDeeBfs6XnHrNtFhR/iP6g=; b=gte70UkAcnSPyi/G 0GFXA0zuoEmlpRzXw67/jZA3e0GDYqJvoYUAq50YfQwjujzK11nui4SfiTTd3ozR oQDh+RoCTXaEn3skROMB3DNulmqe9D9unZgWMTymfkwvNLiLpXXG6dbm3qJQg9mA td0zrrIEEk7bEXv9brW+aMdrlGOT7jIDsd00DbFSyV1/L50dTQyG4CUpVhKCkQEF njV60Dwq4ndEW1i0M6Ic3xEldE4DfLZHHYtF7qCHAKgDRyU+ZWNZXQGVLEQA22Ko Knz0Xeq1Q2WZ3Prf91qAcvZJazL+mTMn9hbvFhgmDOkrB9Tmw+ypvAb6x1IfKaUH +qjIdg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=sltyfScQEcv4ynVkeMQEENDeeBfs6XnHrNtFhR/iP 6g=; b=v36e3d0o2Om7KdM75IScUocUmPGu3S9XBDopyWOSYJYV75n8HDN3ia1+X 1RFkwdRcFm3gKchhuBp8whMfwGYICIV+YjLr4U22eV63jksEEwbSShseVaqUt4IV hCJWobjjlNWthRI6nP8Yc80fEyPiKe6oSGl1behCdRZYtHMsC5w6xbY4fBxrE+zg KI6xLlTksObJNqdKWXxwRVM0VG0I2C2WTslU0EZkkcn8wZB0+N+uYoOB5uYeIPX3 PSq5aiM+svjxSXgNR4N7jV8mIGRzkNmHloGZXcHEKJOPss0NsKYMS6bzCYMpj9yA +0ZrI5W3PZl/ERYZhkcTxgWIEUrQg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdeikedguddvvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdev uedtjeevheevteenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 19 May 2021 03:56:12 -0400 (EDT) From: Thomas Monjalon To: John Griffin , Fiona Trahe , Deepak Kumar Jain , Jerin Jacob , Herbert Guan Cc: stable@dpdk.org, dev@dpdk.org, david.marchand@redhat.com, nd@arm.com, Feifei Wang , Ruifeng Wang Date: Wed, 19 May 2021 09:56:11 +0200 Message-ID: <10811692.tepGkDS67r@thomas> In-Reply-To: <20210517090709.4078-1-feifei.wang2@arm.com> References: <20210514074113.2666225-1-feifei.wang2@arm.com> <20210517090709.4078-1-feifei.wang2@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] crypto/qat: fix uninitilized compiler warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/05/2021 11:07, Feifei Wang: > In Arm platform, when "RTE_ARCH_ARM64_MEMCPY" is set as true, compiler > will report variable uninitilized warning: >=20 > ../drivers/crypto/qat/qat_sym_session.c: > In function =E2=80=98partial_hash_compute=E2=80=99: > ../lib/eal/include/generic/rte_byteorder.h:241:24: warning: > =E2=80=98=E2=80=99 may be used uninitialized in this function > [-Wmaybe-uninitialized] > 241 | #define rte_bswap32(x) __builtin_bswap32(x) > ... >=20 > This is because "digest" will be initialized by "rte_memcpy" function > rather than "memcpy" if "RTE_ARCH_ARM64_MEMCPY" is set as true. However, > compiler cannot know it is initialized by the function. >=20 > To fix this, use "calloc" to initialize "digest". >=20 > Fixes: cd7fc8a84b48 ("eal/arm64: optimize memcpy") > Cc: stable@dpdk.org >=20 > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > --- > v2: add check and free for memory dynamic allocation (David Marchand) > v3: fix compiler error I am not confortable applying this patch without PMD maintainers ack.