From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D5FAA04DB; Fri, 16 Oct 2020 18:40:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5C5392D41; Fri, 16 Oct 2020 18:40:54 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 6CA9798 for <dev@dpdk.org>; Fri, 16 Oct 2020 18:40:52 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 47BA55C00B1; Fri, 16 Oct 2020 12:02:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 16 Oct 2020 12:02:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= Qc8hENbRPNNzF4FeHBYPHtusZLZgECiZ4b8jo6ukXIs=; b=E8q8ySsfvDNQUSM4 jZKJIJLhI8IYEcSMHZU0EWM74j72YYzxo92LBNQsH3P7qBj63FpV33EpiiBCs6no uUl5Br6YL8wo2m+mD+SWLo6kReXNil8ZgZ26Ew/oFHUL91t/fc8XP5wuihMGfyXF /T+iaffNc5b9s3ZP8Vz1fTZc27gEwTi7i/h3qUvs0LvG09rZfCZcsZGLScWhU2uG cC1gUXXBuiVauOkmWhtFqIvLnTgKRMH259LRN6axfTTJ5mRj9Lb4JaIUwMfWU5XQ 9RF75p2jcSrU4mgX/qo711w3ruEPKNGaIXn/scC2AlJxpKLwve1QAD2Q9ww/6wSG OIyDtA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Qc8hENbRPNNzF4FeHBYPHtusZLZgECiZ4b8jo6ukX Is=; b=VH7e5lXAHgnEac1EETUEw3ySSp9//qc6cQ2xw25jU53L8+en2MaIMYeDs XLUh1BeJaFHEVQo3HjhraVAL6WptprCHiuKeAcviXSlMX2W7TPAHyg/Tog17vwPd A01wbRdDRARbFoR0nCddBQoE9iq6yNeT75iCEau+wNDCXlelZyP+0FmkpVZfggZJ LMDqTrt4XcyjoAIei2qROr3NC5M41YdZA0556RrkVuJMt+U+gsCOi6bZcoVhsBGR 2a8va1oVkisOXvzBHURJzS4LGSWbsFng+Ey0CpPZRaltQj5kFZ9U0WtgL8LOONgz P8k2xtD6/P97NCXD9wyKaoupIbCUQ== X-ME-Sender: <xms:BsSJX8i6sS0HGRL6BpMWpbxrBAfibA4ly1MVPUpc0AlSinAteyvo6w> <xme:BsSJX1BT0goUxPEdgFrT3gvdZCQYF6YIffFMNXcUUh70udrHu_pcOA5OyT7f8rjSD -n-OXEoAyYUty0Wcw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrieehgdeljecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeehteff vdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvd dtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:BsSJX0Gxh7eaqdPXL1PjMBNEJRgoSG_tRYOJVJla2-kDpkrJS7AytA> <xmx:BsSJX9RK1hhlhYrj23EADY4AppKtSB5d1BrDyZATj31oKsKdvNQw1A> <xmx:BsSJX5wYLCrbXpbYqAaDne5YyKn0ntARqh8tgf72YRYzN03XG9px1w> <xmx:CMSJX4xRtxZPkIn4arYtjndGnHmBkFz9VZaN5F1QOsktBFy0II4ncw> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 210FE328005A; Fri, 16 Oct 2020 12:02:13 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: "Kinsella, Ray" <mdr@ashroe.eu> Cc: David Marchand <david.marchand@redhat.com>, dev <dev@dpdk.org>, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>, Konstantin Ananyev <konstantin.ananyev@intel.com>, Kevin Traynor <ktraynor@redhat.com>, Bruce Richardson <bruce.richardson@intel.com> Date: Fri, 16 Oct 2020 18:02:12 +0200 Message-ID: <10831349.H8DisTFFRY@thomas> In-Reply-To: <6c1fa16a-891c-b822-3252-47aec20c6bcc@ashroe.eu> References: <20201016093806.20061-1-david.marchand@redhat.com> <CAJFAV8wA-033wVWhM27BVPTvJpvAsNjGi8FDVd+SWpFaWtxO6g@mail.gmail.com> <6c1fa16a-891c-b822-3252-47aec20c6bcc@ashroe.eu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal/windows: fix symbol export X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 16/10/2020 17:48, Kinsella, Ray: > On 16/10/2020 12:22, David Marchand wrote: > > On Fri, Oct 16, 2020 at 1:16 PM Kinsella, Ray <mdr@ashroe.eu> wrote: > >> > >> The windows exports and the map files, feels like duplication of effort. > >> Could we massage one into the other during the build? > > > > That's what is done with map-to-win.py, unless we have one exception > > when the full library is not ready, like EAL. > > > > https://git.dpdk.org/dpdk/tree/lib/meson.build#n152 > > https://git.dpdk.org/dpdk/tree/buildtools/map_to_win.py#n27 > > Thinking about this again - future work might be to check if a .def exists. > And then to warn in checkpatch if one is modified without the other? It would not have avoided this miss, because the symbol has been added in the .def after I've sent my patch removing the function. What missed was a check to run before pushing, and this is what David did in the patch 2 of this series.