From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id D3FA5558D for ; Thu, 12 Jan 2017 20:05:26 +0100 (CET) Received: by mail-wm0-f52.google.com with SMTP id r144so35276758wme.1 for ; Thu, 12 Jan 2017 11:05:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=5+5ikcpH1Du6U3zoqbBjVmhUh/CftBHIC4zhjgNwcHQ=; b=s636Ye+LWwApgs3zXc/LL/rBHvQd4LwAzegXIkB+XkuXrdSjf78oT2DSM6oV+piwRz ywXhRcxqaYp0jAyE1JHitQdqWLwcU1ai0lB1lypRyc8HMeFPndfVf9o3lugCu4pbN2HA jGfwBIW6HnxivvkVROC9SwLw6mwLqFdqNRedDdZeksHzg9FFOnsbMMv8Br+aoVCeMHoG efqhwp7XUEKAYx092AmyJ4dnuWjfbmwC7aD7+if3scJW6dmXvpPOWT/33noVYCWbSF3f uhM17/AxHE3sTT2fF+M+FwcwAUlmxvfiAmH+o8Qjenq7AFZwVad5RWJtRhuiaGZ9P6YH YIEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=5+5ikcpH1Du6U3zoqbBjVmhUh/CftBHIC4zhjgNwcHQ=; b=XK8fnwaXgiHA3PPjYfctkFVmBlv2faJn27vxHjlYG6TEzs8gWTN5zvNimsNv0oSQwN nJrWSim+klfXZ33k63fa4qCO9bIN+uiItH8vn5bI3yD0ZBJUM+8w/RxVLv0uWGxMZuU3 lLj0UpHa7fb3CEtHmwLEG5Q53L0Z9X7ozb8mZmxFOZ3FUot8zWemPphoy6O4kKEP/fcE 5y3kaLp8xvHN+wmBRPDcvDuyuNyEXTbGOEIQURmss81wCfQd9BnPPRYjlJmeBSBHSsQN So59cyeSaQiu+Bn0jwX1Z6vmSmCr9VIJZjlQgCON6joMaf7v8hwQsGOTglymOrccB8Kn jt7Q== X-Gm-Message-State: AIkVDXIo0TFmGCeXvYVSRiDsVBqM+ckVsgJs6g+qq+d9zfSjANM0615DNRNd2HA5MxhR7fop X-Received: by 10.28.178.142 with SMTP id b136mr9810811wmf.69.1484247925819; Thu, 12 Jan 2017 11:05:25 -0800 (PST) Received: from xps13.localnet (113.204.154.77.rev.sfr.net. [77.154.204.113]) by smtp.gmail.com with ESMTPSA id 191sm4852481wmo.21.2017.01.12.11.05.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Jan 2017 11:05:25 -0800 (PST) From: Thomas Monjalon To: Remy Horton Cc: dev@dpdk.org Date: Thu, 12 Jan 2017 20:05:22 +0100 Message-ID: <10847386.FvRstgEsi2@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1484150594-3758-1-git-send-email-remy.horton@intel.com> <1951093.Zqtj2Qm3TA@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 1/4] lib: add information metrics library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2017 19:05:27 -0000 2017-01-12 15:30, Remy Horton: > > On 12/01/2017 13:22, Thomas Monjalon wrote: > > 2017-01-12 00:03, Remy Horton: > [..] > >> --- /dev/null > >> +++ b/lib/librte_metrics/rte_metrics.h > >> +/** Used to indicate port-independent information */ > >> +#define RTE_METRICS_NONPORT -1 > > > > I do not understand this constant. > > Why using the word "port" to name any device? > > What means independent? > > The metric library hold two sets of values: Ones specific to ports, and > ones that are global/aggregate. Agree "non port" is not the clearest > choice of name.. I think you should not use the word "port" at all.