DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Yuan Wang <yuanx.wang@intel.com>, chenbo.xia@intel.com
Cc: dev@dpdk.org, jiayu.hu@intel.com, xingguang.he@intel.com,
	stable@dpdk.org
Subject: Re: [PATCH v2] examples/vhost: fix floating point exception when no VMDq
Date: Wed, 1 Jun 2022 12:09:48 +0200	[thread overview]
Message-ID: <10850373-1da4-9892-7ba5-2a8ada6b1b3f@redhat.com> (raw)
In-Reply-To: <20220518133633.1634902-1-yuanx.wang@intel.com>



On 5/18/22 15:36, Yuan Wang wrote:
> If the VMDQ limits is 0, a divide-by-zero error occurs.
> This patch replaces throwing a floating point exception with
> a normal error message.
> 
> Fixes: d19533e86f ("examples/vhost: copy old vhost example")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
> ---
>   examples/vhost/main.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index c4d46de1c5..48d9f3802f 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -400,6 +400,10 @@ port_init(uint16_t port)
>   
>   		return retval;
>   	}
> +	if (dev_info.max_vmdq_pools == 0) {
> +		RTE_LOG(ERR, VHOST_PORT, "Failed to get VMDQ info.\n");
> +		return -1;
> +	}
>   
>   	rxconf = &dev_info.default_rxconf;
>   	txconf = &dev_info.default_txconf;


Applied to dpdk-next-virtio/main.

Thanks,
Maxime


      parent reply	other threads:[~2022-06-01 10:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 16:34 [PATCH] examples/vhost: fix floating point exception when there is no VMDQ Yuan Wang
2022-05-16 12:57 ` Xia, Chenbo
2022-05-17 10:14   ` Wang, YuanX
2022-05-18 13:36 ` [PATCH v2] examples/vhost: fix floating point exception when no VMDq Yuan Wang
2022-05-30  2:52   ` Xia, Chenbo
2022-06-01 10:09   ` Maxime Coquelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10850373-1da4-9892-7ba5-2a8ada6b1b3f@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=jiayu.hu@intel.com \
    --cc=stable@dpdk.org \
    --cc=xingguang.he@intel.com \
    --cc=yuanx.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).