From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 371CAA0548; Wed, 1 Jun 2022 12:09:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 27D8640694; Wed, 1 Jun 2022 12:09:59 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C7DBE40696 for ; Wed, 1 Jun 2022 12:09:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654078196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B7av9F4osKyHVGU2tzoyFKlGWQspsZieeMdlZGSZchs=; b=Nv0CaQ5WXKN4zqMgDaxEN1PLtnyUijvT5EZf5eXp5vCFt48oA28td9ZtVk+3vdfaZC2Zc4 IEKoCXDu2dlNcwjSsPwqmygmbN+8x1BL3SGz9uMLnMSq/Tr6OU+koKkYhtidHndmxHmhvz EyHw5hFh0wOk6cPQojb+t2nfNOzTEYA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-267-1cAoihXCOBaIDFVoaVgyCw-1; Wed, 01 Jun 2022 06:09:52 -0400 X-MC-Unique: 1cAoihXCOBaIDFVoaVgyCw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DFEC43801EC1; Wed, 1 Jun 2022 10:09:51 +0000 (UTC) Received: from [10.39.208.26] (unknown [10.39.208.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BD366C27E8F; Wed, 1 Jun 2022 10:09:50 +0000 (UTC) Message-ID: <10850373-1da4-9892-7ba5-2a8ada6b1b3f@redhat.com> Date: Wed, 1 Jun 2022 12:09:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] examples/vhost: fix floating point exception when no VMDq To: Yuan Wang , chenbo.xia@intel.com Cc: dev@dpdk.org, jiayu.hu@intel.com, xingguang.he@intel.com, stable@dpdk.org References: <20220411163451.572814-1-yuanx.wang@intel.com> <20220518133633.1634902-1-yuanx.wang@intel.com> From: Maxime Coquelin In-Reply-To: <20220518133633.1634902-1-yuanx.wang@intel.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/18/22 15:36, Yuan Wang wrote: > If the VMDQ limits is 0, a divide-by-zero error occurs. > This patch replaces throwing a floating point exception with > a normal error message. > > Fixes: d19533e86f ("examples/vhost: copy old vhost example") > Cc: stable@dpdk.org > > Signed-off-by: Yuan Wang > --- > examples/vhost/main.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/examples/vhost/main.c b/examples/vhost/main.c > index c4d46de1c5..48d9f3802f 100644 > --- a/examples/vhost/main.c > +++ b/examples/vhost/main.c > @@ -400,6 +400,10 @@ port_init(uint16_t port) > > return retval; > } > + if (dev_info.max_vmdq_pools == 0) { > + RTE_LOG(ERR, VHOST_PORT, "Failed to get VMDQ info.\n"); > + return -1; > + } > > rxconf = &dev_info.default_rxconf; > txconf = &dev_info.default_txconf; Applied to dpdk-next-virtio/main. Thanks, Maxime