From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 6A85A1B47E for ; Thu, 22 Nov 2018 23:44:54 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id ED03922105; Thu, 22 Nov 2018 17:44:53 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 22 Nov 2018 17:44:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Mm+mCTxJxEHZXkbEFjE2TDu1lc5yrQho1OOg67MWrbs=; b=HbZEwBZy3QTz oBdPSVbccJ5bN/ObEL55nmPiO2U5v02BvroeV88w1WsZTSlZmm6saL+yQCOLQiZa 5seZe5jWv63ckCspbgC5fZqp8j/79LF2dnOXKPIINCpUltz9tvu1KZiEhDE4hdMR b4xnqqJcaxJrqThz1xUZaUpgXgSNHD0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Mm+mCTxJxEHZXkbEFjE2TDu1lc5yrQho1OOg67MWr bs=; b=lnFAljIfcSjBShksQ7B4qOZ7Obcg2fm50GDH6TRaKEwWL8FPXz+DOleAq PCtcDGqKLuJ7KgRJCQmmn//g8sWll6ZXu4EmsywRkUCrpfJvXdHqrFwb+8NjdETb fknFPgEGZSOX5ppeD44gW9l+UM7bpSM3egok/RDnDp/CGv548dGkFT78CTRnSN4G UtEEnhznSdmqW3h3Vmu3hDs3uCDoBUeCJWnSW3xvBOmNV/aPlZeGscekPjXQE3py 8QoMUMlgGzskyGlb5oSMtnKKRZTBwjOHA7Nu24THrB+ZbUn/JXGzraQJ6410g14x teXsyn4dWteEs0vQIv8Rg+GhU4AMQ== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 41F6CE47C4; Thu, 22 Nov 2018 17:44:52 -0500 (EST) From: Thomas Monjalon To: "Ananyev, Konstantin" Cc: dev@dpdk.org, "Burakov, Anatoly" , Neil Horman , "Mcnamara, John" , "Kovacevic, Marko" , "Dumitrescu, Cristian" , "Singh, Jasvinder" , "Yigit, Ferruh" , "Richardson, Bruce" Date: Thu, 22 Nov 2018 23:44:50 +0100 Message-ID: <10867117.EFarvljQJ7@xps> In-Reply-To: <2601191342CEEE43887BDE71AB977258010CEBB04A@IRSMSX106.ger.corp.intel.com> References: <6279ff04d7d477d3c2c076c643a0093aecb654c6.1542801670.git.anatoly.burakov@intel.com> <2601191342CEEE43887BDE71AB977258010CEBB04A@IRSMSX106.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/2] bitmap: deprecate and rename rte_bsf64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2018 22:44:54 -0000 22/11/2018 19:56, Ananyev, Konstantin: > > Rename rte_bsf64 to rte_bsf64_safe (this is a "safe" version in > > that it prevents undefined behavior by checking if incoming > > parameter is zero) and move it to common header. > > Probably a stupid one: why to rename? > Why just not fix rte_bsf64 to make it work with zero value, > and keep the same function name? Because there are different parameters and returned value than rte_bsf32. In the next release, we will have rte_bsf64 function, behaving as rte_bsf32. This is explained in the deprecation notice. [...] > > +static inline int > > +rte_bsf64_safe(uint64_t v, uint32_t *pos)