From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A400A0C43; Thu, 23 Sep 2021 19:17:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D870341260; Thu, 23 Sep 2021 19:17:47 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id A76C041257; Thu, 23 Sep 2021 19:17:46 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 49A0A5C011C; Thu, 23 Sep 2021 13:17:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 23 Sep 2021 13:17:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= +m1p79qtMEwtBLBasUTD4+QTClxRgVpJZUNBzitGd9Q=; b=eFF+EEB+QCMh8cVv eWcKrcXJSV9ne6IG35/xxSMaXk481jHKcSoIrJq28stSr2NammQyfIYtBToJAzIG z/sU1aBXNgRxxAnPw9H3Rwz0uMLsfOIRTB2NVQhkOwtSBImA2Hgs74WAxVGZlTA4 TTgxDyPKn6PgQ0JpnUso/fCSSaibLGgirG6UmnSmsNMrvREtPwEIfw8YsGDACNnp nexCidX7AAk+KKDXRuLvsYzi2xWMIEtxOulTnvTCKFvQw2K1zzeYe0a7iYQ+Fs+c bp4Px/IiLFm6+5SamPheDXkQ617wm5YAtu6Owf7QylgedAtkd/tZ2WfJqSFaTtPM RtQHDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=+m1p79qtMEwtBLBasUTD4+QTClxRgVpJZUNBzitGd 9Q=; b=a7meH5hCv4gBduB5XRC7XDpV2dUsIE9YrPfPAecGbiPkTkB9BxnUOiaik rHCTOLS63FAQuCviH6Ajhb8Xwsxm1hABtq3biqUIBKEmRjEIEhwIydZK2+owM6SY tz2BWsauKA85YtXGQYbAhC9rm0FvJu3s7bCT3sIadfhjWXcYctvkwnlscJu71QhL YlVaQ1q7ghs+D/p0QW5oFgHtIINvTkjSUeVvViuU0xm31i7ZwsAFP12nGSrFtkog easjWzafYG5tioQ0RA5EMzRDx9NrzzczHBLzSQdtu1u4naVbijDONNIKGXv7I1LW K+OkK5hOW24wqVP0vtGCmxySLb9og== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudeiledguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 23 Sep 2021 13:17:45 -0400 (EDT) From: Thomas Monjalon To: Tal Shnaiderman Cc: dev@dpdk.org, pallavi.kadam@intel.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, stable@dpdk.org, Dmitry Kozlyuk Date: Thu, 23 Sep 2021 19:17:44 +0200 Message-ID: <10884954.bRuhss97Ub@thomas> In-Reply-To: <20210915222514.259bc13b@sovereign> References: <20210913165500.21636-1-talshn@nvidia.com> <20210915222514.259bc13b@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal/windows: fix token pasting build warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/09/2021 21:25, Dmitry Kozlyuk: > 2021-09-13 19:55 (UTC+0300), Tal Shnaiderman: > > When building DPDK on Windows in debug mode the following > > warning appear: > > > > warning: token pasting of ',' and __VA_ARGS__ is a GNU extension > > [-Wgnu-zero-variadic-macro-arguments] #define open(path, flags, ...) > > _open(path, flags, ##__VA_ARGS__) > > > > Modified the 'open' macro to avoid it. > > Nit: "Modify" (present tense should be used here). > > > > > Fixes: 45d62067c237 ("eal: make OS shims internal") > > Cc: stable@dpdk.org > > > > Signed-off-by: Tal Shnaiderman > > --- > > -#define open(path, flags, ...) _open(path, flags, ##__VA_ARGS__) > > +#define open(...) _open(__VA_ARGS__) > > Note: Three-argument form of open() is seldom used in DPDK and only once > in OS-independent code. However, rte_os_shim.h can be included > in platform-specific file and it should not prevent using 3-argument open(). > This patch is probably the most simple and robust thing we can do. > > Acked-by: Dmitry Kozlyuk Applied, thanks.