From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: dev@dpdk.org
Cc: Damjan Marion <damarion@cisco.com>
Subject: Re: [dpdk-dev] [PATCH 21.02 v2] mem: don't warn about base addr if not requested
Date: Fri, 22 Jan 2021 17:21:02 +0000 [thread overview]
Message-ID: <108cb3e3-3ca6-996d-9822-05dde4c657c1@intel.com> (raw)
In-Reply-To: <8f49e252a7be2d8561f4b32193e5800f98c40b0e.1604936860.git.anatoly.burakov@intel.com>
On 09-Nov-20 3:47 PM, Anatoly Burakov wrote:
> Any EAL memory allocation often goes through eal_get_virtual_area()
> function, which will print a warning whenever the resulting allocation
> didn't match the specified address requirements. This is useful for
> when we have requested a specific base virtual address, to let the user
> know that the mapping has deviated from that address.
>
> However, on Linux, we also have a default base address that's there to
> ensure better chances of successful secondary process initialization,
> as well as higher likelihood of the virtual areas to fit inside the
> IOMMU address width. Because of this default base address, there are
> warnings printed even when no base address was explicitly requested,
> which can be confusing to the user.
>
> Emit this warning with debug level unless base address was explicitly
> requested by the user.
>
> Cc: Damjan Marion <damarion@cisco.com>
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>
> Notes:
> v2:
> - Fix the condition to not update the address incorrectly
> - Instead of removing the warning, let it have debug level unless base address
> was explicitly specified by the user
>
> I'm not entirely sure the trade off between user confusion and helpful debug
> information is worth it, but in my experience, i've stopped getting any emails
> about secondary processes a long time ago and this isn't a widely used feature,
> so i believe this is worth it.
For some reason i didn't get David's comment in my inbox, so i'll copy
it here:
> EAL options like --in-memory or --no-shconf makes MP unusable.
> If we add a rte_mp_disable() for them, we could check here for MP
> status here and display nothing at all.
> WDYT?
That sounds like a nice idea, but this patch addresses a different issue.
--
Thanks,
Anatoly
next prev parent reply other threads:[~2021-01-22 17:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 15:27 [dpdk-dev] [PATCH 21.02] " Anatoly Burakov
2020-11-09 15:47 ` [dpdk-dev] [PATCH 21.02 v2] " Anatoly Burakov
2021-01-12 10:29 ` David Marchand
2021-01-22 17:21 ` Burakov, Anatoly [this message]
2022-01-28 11:17 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=108cb3e3-3ca6-996d-9822-05dde4c657c1@intel.com \
--to=anatoly.burakov@intel.com \
--cc=damarion@cisco.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).