From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ferruh.yigit@intel.com> Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 95F36106A for <dev@dpdk.org>; Tue, 13 Dec 2016 16:07:54 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 13 Dec 2016 07:07:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,342,1477983600"; d="scan'208";a="797518435" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by FMSMGA003.fm.intel.com with ESMTP; 13 Dec 2016 07:07:51 -0800 To: Andrew Rybchenko <arybchenko@solarflare.com>, Shreyansh Jain <shreyansh.jain@nxp.com>, dev@dpdk.org, david.marchand@6wind.com References: <1480846288-2517-1-git-send-email-shreyansh.jain@nxp.com> <1481636232-2300-1-git-send-email-shreyansh.jain@nxp.com> <1481636232-2300-13-git-send-email-shreyansh.jain@nxp.com> <44213d68-1e87-c464-549a-274e389b9c0f@solarflare.com> Cc: thomas.monjalon@6wind.com, jianbo.liu@linaro.org From: Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <108fb50f-a5da-1646-5dc4-23b03be6a02e@intel.com> Date: Tue, 13 Dec 2016 15:07:51 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <44213d68-1e87-c464-549a-274e389b9c0f@solarflare.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 12/12] drivers: update PMDs to use rte_driver probe and remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 13 Dec 2016 15:07:55 -0000 On 12/13/2016 1:52 PM, Andrew Rybchenko wrote: > On 12/13/2016 04:37 PM, Shreyansh Jain wrote: >> These callbacks now act as first layer of PCI interfaces from the Bus. >> Bus probe would enter the PMDs through the rte_driver->probe/remove >> callbacks, falling to rte_xxx_driver->probe/remove (Currently, all the >> drivers are rte_pci_driver). > > I think similar changes in drivers/net/sfc/sfc_ethdev.c (already in > dpdk-next-net) are required as well. Yes, that change is required, but it is a little tricky because this patchset targets main tree where sfc is not merged yet, so this patch can't include required patches. I think it is possible to wait for this patch to be merged into main tree, and when next-net rebased on top of it, sfc can be patched individually. So, yes there is a work to do there, but I think it can be postponed a little. > >> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com> >> --- >> drivers/net/bnx2x/bnx2x_ethdev.c | 8 ++++++++ >> drivers/net/bnxt/bnxt_ethdev.c | 4 ++++ >> drivers/net/cxgbe/cxgbe_ethdev.c | 4 ++++ >> drivers/net/e1000/em_ethdev.c | 4 ++++ >> drivers/net/e1000/igb_ethdev.c | 8 ++++++++ >> drivers/net/ena/ena_ethdev.c | 4 ++++ >> drivers/net/enic/enic_ethdev.c | 4 ++++ >> drivers/net/fm10k/fm10k_ethdev.c | 4 ++++ >> drivers/net/i40e/i40e_ethdev.c | 4 ++++ >> drivers/net/i40e/i40e_ethdev_vf.c | 4 ++++ >> drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++++++++ >> drivers/net/mlx4/mlx4.c | 4 +++- >> drivers/net/mlx5/mlx5.c | 1 + >> drivers/net/nfp/nfp_net.c | 4 ++++ >> drivers/net/qede/qede_ethdev.c | 8 ++++++++ >> drivers/net/szedata2/rte_eth_szedata2.c | 4 ++++ >> drivers/net/thunderx/nicvf_ethdev.c | 4 ++++ >> drivers/net/virtio/virtio_ethdev.c | 2 ++ >> drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++++ >> 19 files changed, 86 insertions(+), 1 deletion(-) <...>