From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB4D3A0C55; Wed, 13 Oct 2021 12:29:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A2981410DA; Wed, 13 Oct 2021 12:29:17 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id EC7F340E64; Wed, 13 Oct 2021 12:29:15 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="214339664" X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="214339664" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 03:29:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="563055213" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP; 13 Oct 2021 03:29:14 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 03:29:14 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 18:29:12 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.012; Wed, 13 Oct 2021 18:29:12 +0800 From: "Zhang, Qi Z" To: "Guo, Junfeng" , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" , "Yigit, Ferruh" Thread-Topic: [PATCH] net/ice/base: fix null pointer dereferences for parser Thread-Index: AQHXv9z+dR1YlSXVmEKoJCTPJGdI1qvQum+w Date: Wed, 13 Oct 2021 10:29:11 +0000 Message-ID: <109367a246e44fc8a0061b1f2872c9de@intel.com> References: <20211013103455.3256151-1-junfeng.guo@intel.com> In-Reply-To: <20211013103455.3256151-1-junfeng.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ice/base: fix null pointer dereferences for parser X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Guo, Junfeng > Sent: Wednesday, October 13, 2021 6:35 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; stable@dpdk.org; Yigit, Ferruh = ; > Guo, Junfeng > Subject: [PATCH] net/ice/base: fix null pointer dereferences for parser >=20 > Null-checking "p" suggests that it may be null, but it has already been > dereferenced on all paths leading to the check. Thus correct the code lin= es and > remove the redundant line. >=20 > Fixes: c84f8aa2100c ("net/ice/base: add parser runtime skeleton") > Cc: stable@dpdk.org >=20 > Signed-off-by: Junfeng Guo Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi