From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C10765583 for ; Wed, 21 Jun 2017 12:00:25 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 49E4B20A7E; Wed, 21 Jun 2017 06:00:25 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 21 Jun 2017 06:00:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=iyazF6N2rGrJO0m DmkzIWo52Bb6FCEx+vRqVSIIoDZU=; b=P+bQv2SOL5h1gQv5qoXlhIN16rRed3m UmNt52QkukZxMDWS9tBm8s29QRi72vV58fQ1fpvqmszrACFtZN1V+/355dh+q8qh 3fWzns17N6bzCC0HshYtDALqp3GCZJ0AcN2QsSIMpFmnYXXrtLA+82XGa9Kkb5/R Mh2B6SpR4P0Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=iyazF6N2rGrJO0mDmkzIWo52Bb6FCEx+vRqVSIIoDZU=; b=WtxCNmYZ iUcWv/7txVd4onlpUQOVD+dGGwwhrRHE04Y1iA6NFCiswvwMqKmZaBcZbmwKdBVq kzS3s8e8YGq6FPBcZeRgpL8CnR1UMUFXHUbC0o1/a3Nda6ngQ7v+Se2eeHHtadie UPpysswhsS4+aW8mG2kWJA1qXkUQnzJkInxenQ1vRs34g0JxCVMkt8VIMLpuVpij k2dNefhqZDBA41dWx/02b84Nigk2umSjBErMHEtxIuWSC7TmYIDVeaPZUiIdoSsp xkcCB7/w4vsaLELUvQ3hnrzx71Z3DF0BIx9NBjEdUOug3pptlrsy70vul6lXety3 n7aI/1CyUyvBdg== X-ME-Sender: X-Sasl-enc: FmIvHEwHMU2unzL1ywTOosuo4ekHgYrK9+77dcFuQlk7 1498039225 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 06AE3245EF; Wed, 21 Jun 2017 06:00:25 -0400 (EDT) From: Thomas Monjalon To: =?ISO-8859-1?Q?Ga=EBtan?= Rivet Cc: dev@dpdk.org Date: Wed, 21 Jun 2017 12:00:24 +0200 Message-ID: <10937675.k8W90Yh6uJ@xps> In-Reply-To: <20170621094026.GD2344@bidouze.vm.6wind.com> References: <8418992.7tWpiUoDtu@xps> <20170621094026.GD2344@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH v3 5/9] pmdinfogen: move to drivers subdirectory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2017 10:00:26 -0000 21/06/2017 11:40, Ga=EBtan Rivet: > On Wed, Jun 21, 2017 at 09:57:18AM +0200, Thomas Monjalon wrote: > > Another (probably better) solution is to keep basic definitions > > and helpers in EAL: > > - rte_pci.h keeps only some PCI definitions and helpers > > like rte_pci_addr and eal_parse_pci_BDF() in EAL > > - bus management is done in the PCI driver > >=20 > > For pmdinfogen, we just need struct rte_pci_id. > > Other tools or applications will probably need this kind of basic > > struct and functions available in EAL. >=20 > I mostly agree, this proposal should be kept to a minimum at first for > this release and carefully expanded afterward. >=20 > If that's ok, I will propose a new version of this patchset with a new > librte_pci, that might fix both pmdinfogen and librte_kni. Why creating a new librte_pci instead of just keeping it in EAL?