From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 99AD54C95 for ; Tue, 2 Apr 2019 12:03:17 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2D4F92211F; Tue, 2 Apr 2019 06:03:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 06:03:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=KjQH/N7tT7NgPH2+PC/BbT9/C5xhbrErwubhNEVNcts=; b=AjokzjWmPz5v pjE3wJlMBp2AAjYHWORw/38GLoTdf3Ysqs0Txw7jriSuTscv0yiqOwMwEK0W+16B zSoYmAUae8NNOHdToQmRb5LQawgue6KM14hdjSU/KveH3TBcnjWqpNtZHJgbigse ndS2fsLwkXOOO3d/nX8afs1isMQXlBc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=KjQH/N7tT7NgPH2+PC/BbT9/C5xhbrErwubhNEVNc ts=; b=45sEKQh6FGkdLFk49JBfiE8XiBuVtGVFOrZoZVJWZErxuizxKJM2Rpda8 AZ78OVM/nwyMt4Vn9e2qd9ByZeqswrDV2I+pjv70IWg8+mowZRYFFW95X4hewEly +D3y9yGiGsbJ5Yc5MXktWcP/Tev//w8IgODHwLZgKi1SQNwebgkes/Jz6qzHnrG4 VLMfpj6JCNMPmBquAMaLJc0ujEVkskOm6RfS9DEmJ/yZYsreE8EJONL1/8RTmVd9 NM49YdTSvLOxRcPo5yXxvKOpp8hUqO3unbxjEk0cQ51fdsOQmlE+GqaGmLAsHo4w fDi2v2UrbzPX7kSvNPpayMFCgMNpA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddtgddtfeculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C4E13E4210; Tue, 2 Apr 2019 06:03:15 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev , Bruce Richardson , Anand Rawat Date: Tue, 02 Apr 2019 12:03:14 +0200 Message-ID: <10947252.tCyXudDSDa@xps> In-Reply-To: References: <20190401230712.31864-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: remove exec-env directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 10:03:17 -0000 02/04/2019 11:57, David Marchand: > On Tue, Apr 2, 2019 at 1:07 AM Thomas Monjalon wrote: > > > Only one header file (rte_kni_common.h) was in the sub-directory > > include/exec-env/ > > This file was installed in a sub-directory of the same name. > > Source and install directories are moved as below: > > > > lib/librte_eal/linux/eal/include/exec-env/ > > -> lib/librte_eal/linux/eal/include/ > > > > build/include/exec-env/ > > -> build/include/ > > > > The consequence is to have a file hierarchy a bit more flat. > > > > Signed-off-by: Thomas Monjalon > > --- > > devtools/check-includes.sh | 1 - > > kernel/linux/kni/kni_dev.h | 2 +- > > kernel/linux/kni/kni_fifo.h | 2 +- > > kernel/linux/kni/kni_misc.c | 2 +- > > kernel/linux/kni/kni_net.c | 2 +- > > lib/librte_eal/freebsd/eal/Makefile | 3 +-- > > lib/librte_eal/linux/eal/Makefile | 3 +-- > > .../linux/eal/include/{exec-env => }/rte_kni_common.h | 0 > > lib/librte_kni/rte_kni.c | 2 +- > > lib/librte_kni/rte_kni.h | 2 +- > > 10 files changed, 8 insertions(+), 11 deletions(-) > > rename lib/librte_eal/linux/eal/include/{exec-env => }/rte_kni_common.h > > (100%) > > > > Think you missed some bits in meson. > lib/librte_eal/linux/eal/meson.build:install_subdir('include/exec-env', > install_dir: get_option('includedir')) You're right. I wonder how I have missed it! In my poor understanding of meson, I think I just have to remove this line. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id E4F10A0679 for ; Tue, 2 Apr 2019 12:03:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9B37E4C96; Tue, 2 Apr 2019 12:03:18 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 99AD54C95 for ; Tue, 2 Apr 2019 12:03:17 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2D4F92211F; Tue, 2 Apr 2019 06:03:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 06:03:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=KjQH/N7tT7NgPH2+PC/BbT9/C5xhbrErwubhNEVNcts=; b=AjokzjWmPz5v pjE3wJlMBp2AAjYHWORw/38GLoTdf3Ysqs0Txw7jriSuTscv0yiqOwMwEK0W+16B zSoYmAUae8NNOHdToQmRb5LQawgue6KM14hdjSU/KveH3TBcnjWqpNtZHJgbigse ndS2fsLwkXOOO3d/nX8afs1isMQXlBc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=KjQH/N7tT7NgPH2+PC/BbT9/C5xhbrErwubhNEVNc ts=; b=45sEKQh6FGkdLFk49JBfiE8XiBuVtGVFOrZoZVJWZErxuizxKJM2Rpda8 AZ78OVM/nwyMt4Vn9e2qd9ByZeqswrDV2I+pjv70IWg8+mowZRYFFW95X4hewEly +D3y9yGiGsbJ5Yc5MXktWcP/Tev//w8IgODHwLZgKi1SQNwebgkes/Jz6qzHnrG4 VLMfpj6JCNMPmBquAMaLJc0ujEVkskOm6RfS9DEmJ/yZYsreE8EJONL1/8RTmVd9 NM49YdTSvLOxRcPo5yXxvKOpp8hUqO3unbxjEk0cQ51fdsOQmlE+GqaGmLAsHo4w fDi2v2UrbzPX7kSvNPpayMFCgMNpA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddtgddtfeculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C4E13E4210; Tue, 2 Apr 2019 06:03:15 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev , Bruce Richardson , Anand Rawat Date: Tue, 02 Apr 2019 12:03:14 +0200 Message-ID: <10947252.tCyXudDSDa@xps> In-Reply-To: References: <20190401230712.31864-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal: remove exec-env directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402100314.kI99mZ5xRJkpnrC-o6Me1lNruYfjwdY-JGPB78Ehu-4@z> 02/04/2019 11:57, David Marchand: > On Tue, Apr 2, 2019 at 1:07 AM Thomas Monjalon wrote: > > > Only one header file (rte_kni_common.h) was in the sub-directory > > include/exec-env/ > > This file was installed in a sub-directory of the same name. > > Source and install directories are moved as below: > > > > lib/librte_eal/linux/eal/include/exec-env/ > > -> lib/librte_eal/linux/eal/include/ > > > > build/include/exec-env/ > > -> build/include/ > > > > The consequence is to have a file hierarchy a bit more flat. > > > > Signed-off-by: Thomas Monjalon > > --- > > devtools/check-includes.sh | 1 - > > kernel/linux/kni/kni_dev.h | 2 +- > > kernel/linux/kni/kni_fifo.h | 2 +- > > kernel/linux/kni/kni_misc.c | 2 +- > > kernel/linux/kni/kni_net.c | 2 +- > > lib/librte_eal/freebsd/eal/Makefile | 3 +-- > > lib/librte_eal/linux/eal/Makefile | 3 +-- > > .../linux/eal/include/{exec-env => }/rte_kni_common.h | 0 > > lib/librte_kni/rte_kni.c | 2 +- > > lib/librte_kni/rte_kni.h | 2 +- > > 10 files changed, 8 insertions(+), 11 deletions(-) > > rename lib/librte_eal/linux/eal/include/{exec-env => }/rte_kni_common.h > > (100%) > > > > Think you missed some bits in meson. > lib/librte_eal/linux/eal/meson.build:install_subdir('include/exec-env', > install_dir: get_option('includedir')) You're right. I wonder how I have missed it! In my poor understanding of meson, I think I just have to remove this line.