From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D74C8A0518; Thu, 30 Jul 2020 12:16:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B24EC1C00D; Thu, 30 Jul 2020 12:16:46 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id B844F1BFE7 for ; Thu, 30 Jul 2020 12:16:45 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 56C26E0A; Thu, 30 Jul 2020 06:16:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 30 Jul 2020 06:16:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= OJ3Kw3DRbDVq1q1Nq9Gx6IXhVt7UncD+9WxPxSvsK3Y=; b=o0PtEBn3mFaCg8kl BpoK4SKD1NQL4ua8uzccQSNASKH+iRzFz9k89hFjRIDgMs3uqE00VcctGlXdJVHB LzOuZLa95q/GJ5+ukyaw9q3Vj/hlXpFOGL0jA40LnyI7c9IRK8vK4cUkG9wzPP1R LZgOM707OkNrrDWeyxXquiXuXUBmGjVf1swKzdmIHIJ7IYBzLwygiHibpTIT2Uz2 SEuZB3sw1MvdIR997mWOtxE/FD9CE0CabNSuv3M5h7e9r7yFhGlUM9wf0lUEHA3n IJio9SVmwc1pjT1OG9VXuC0Q+HYWwg9oks01VCjU++VOuWmajlms6Z3ZRfe+WLVZ o3AiAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=OJ3Kw3DRbDVq1q1Nq9Gx6IXhVt7UncD+9WxPxSvsK 3Y=; b=eiFJCbcH4WboQCRskm47ayIA7zFXKu8TTqlTXDmhhat32EZvlIqpOVzjO WMFDX6YiCCXe6SSzoE3GX8SYdORetHRqrrdd3vTRz7ZEZjK+YOiA8g+PGHn4pMGP dDwbS4xL7t/paP/APuNYi7aunKGXRYdq/N6CzCb6HUcVMoVN1HmuTy/pefvT+yn7 xqVIfSgGPfRZV5SgFdu71CFuYLjedFv2gSsShpaAElwsXQXnqZOuTT0Zx/uGrogi TYV/Ee94oahqkKkPuNZEg/gIi34hsERJGz/nP5xG3M2ZjMQ5cMOtAzUDfjnMmCWh oUdqVmnw6l+/NjKFB0W5/K00f0ZCg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrieeigddviecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgjfhgggfgtsehtufertd dttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm ohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepudeggfdvfeduffdtfeegle fghfeukefgfffhueejtdetuedtjeeuieeivdffgeehnecukfhppeejjedrudefgedrvddt fedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 59D2C328005E; Thu, 30 Jul 2020 06:16:42 -0400 (EDT) From: Thomas Monjalon To: yang_y_yi@163.com Cc: dev@dpdk.org, jiayu.hu@intel.com, yangyi01@inspur.com, yang_y_yi@163.com, olivier.matz@6wind.com Date: Thu, 30 Jul 2020 12:16:34 +0200 Message-ID: <10959143.08NVAeP5qT@thomas> In-Reply-To: <20200730095610.93384-3-yang_y_yi@163.com> References: <20200730095610.93384-1-yang_y_yi@163.com> <20200730095610.93384-3-yang_y_yi@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/3] mbuf: change free_cb interface to adapt to GSO case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/07/2020 11:56, yang_y_yi@163.com: > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -1193,7 +1193,7 @@ static inline void rte_pktmbuf_attach(struct rte_mbuf *mi, struct rte_mbuf *m) > RTE_ASSERT(m->shinfo != NULL); > > if (rte_mbuf_ext_refcnt_update(m->shinfo, -1) == 0) > - m->shinfo->free_cb(m->buf_addr, m->shinfo->fcb_opaque); > + m->shinfo->free_cb(m, m->shinfo->fcb_opaque); > } > > /** > diff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mbuf/rte_mbuf_core.h > index 8cd7137..d194429 100644 > --- a/lib/librte_mbuf/rte_mbuf_core.h > +++ b/lib/librte_mbuf/rte_mbuf_core.h > @@ -671,7 +671,7 @@ struct rte_mbuf { > /** > * Function typedef of callback to free externally attached buffer. > */ > -typedef void (*rte_mbuf_extbuf_free_callback_t)(void *addr, void *opaque); > +typedef void (*rte_mbuf_extbuf_free_callback_t)(struct rte_mbuf *, void *); I think a deprecation notice is required in 20.08 in order to apply such change in 20.11. Please use --cc-cmd devtools/get-maintainer.sh when sending a patch.