From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id E05DCA00E6 for ; Wed, 12 Jun 2019 23:25:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 902E81BB22; Wed, 12 Jun 2019 23:25:38 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40059.outbound.protection.outlook.com [40.107.4.59]) by dpdk.org (Postfix) with ESMTP id 2BE941D010; Wed, 12 Jun 2019 23:25:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UZY90qxwXWT3sonzp72f5+pYoAzZkjKsdeV+CTrepAw=; b=BL7KxLdvanSOsVHin9lat2IUv5JFqHtQywVByipmEuXAA3qUya91H/AGRdkMtKTypLPHTfWbOMUKCFdviJI81PKHDrkpcMc47+KavKoBLQ77b4ctlam+IGZG7wUsGeY2TF6tn/Qv4674Q7Y6RAe4R7jgZo2VUgl7C0YR5yHkV78= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4058.eurprd05.prod.outlook.com (52.134.68.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1965.14; Wed, 12 Jun 2019 21:25:34 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::24ee:49a5:d686:cbc4]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::24ee:49a5:d686:cbc4%3]) with mapi id 15.20.1987.010; Wed, 12 Jun 2019 21:25:34 +0000 From: Yongseok Koh To: Shahaf Shuler CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix 32b compilation Thread-Index: AQHVIOAz60NwJOt30EuJe1+zlMocAaaYiPwA Date: Wed, 12 Jun 2019 21:25:34 +0000 Message-ID: <10BD7CE0-1B5A-4756-955B-66754A9F2CF1@mellanox.com> References: <20190612053215.5682-1-shahafs@mellanox.com> In-Reply-To: <20190612053215.5682-1-shahafs@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 60553c67-0618-4c2b-7e21-08d6ef7c8191 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB4058; x-ms-traffictypediagnostic: DB3PR0502MB4058: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2887; x-forefront-prvs: 0066D63CE6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(396003)(136003)(376002)(39860400002)(189003)(199004)(11346002)(6636002)(6512007)(256004)(316002)(68736007)(6436002)(6486002)(99286004)(102836004)(486006)(7736002)(305945005)(2616005)(8676002)(476003)(33656002)(81156014)(229853002)(446003)(66066001)(37006003)(64756008)(8936002)(26005)(76176011)(53546011)(6506007)(81166006)(14454004)(66446008)(2906002)(66476007)(66946007)(478600001)(6246003)(450100002)(6116002)(36756003)(186003)(71190400001)(66556008)(4326008)(86362001)(5660300002)(25786009)(76116006)(53936002)(91956017)(6862004)(54906003)(3846002)(71200400001)(73956011); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4058; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: AxIUoMs1f4EoVSS+k8hRzvbXy+AyHXsHsgSnajufmcELiJhcRiKjQD7ky+K/FZNGiLfB1vlcjGIxuNQ9Q5+Ly8tNg/6oCCb3KnZrLEstljQzt3tDZS9GoN8VJ4KdiJpKQoJcR2hOVV0TncvIH+m2GOGyQYYjQ1FObLBcgJchikRjopbR7K9m+2nmZ8+uCP75G2A/mGnXrA+kruR+KpvRfdRZMB0RJL8FOMyQ9Ks9y3EPn11gSbuwCFOJH6jz0ysaWsUGg/YlqFBkRA+Y5XbreHMqHZsRce7uwtn2S2UEioXlU63YO7c5A0sSbZwk78vGSc1S+t/8Kz8nzIQzSUtXVFOOlMrYd8pVdeoCYRtG5qCvptzswN4A527aTzvERZBZShMa7L/jVYw7JKoGHl0f8mCMNHfEN46XRlOujgElfaM= Content-Type: text/plain; charset="us-ascii" Content-ID: <6F551F294C41D84CAAA6965B3699E630@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60553c67-0618-4c2b-7e21-08d6ef7c8191 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2019 21:25:34.7383 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yskoh@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4058 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix 32b compilation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Jun 11, 2019, at 10:32 PM, Shahaf Shuler wrote: >=20 > 32b Compilation output the below error: >=20 > drivers/net/mlx5/mlx5_txq.c: In function 'mlx5_txq_ibv_new': > error: format '%lx' expects argument of type 'long unsigned int', but > argument 8 has type 'off_t' [-Werror=3Dformat=3D] > DRV_LOG(DEBUG, "port %u: uar_mmap_offset 0x%lx", > ^ off_t would have same size as pointer. Changing lx to PRIxPTR would work? > Fixes: 6bf10ab69be0 ("net/mlx5: support 32-bit systems") > Cc: stable@dpdk.org >=20 > Signed-off-by: Shahaf Shuler > --- > drivers/net/mlx5/mlx5_txq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c > index ebb42cbffb..a421139e3c 100644 > --- a/drivers/net/mlx5/mlx5_txq.c > +++ b/drivers/net/mlx5/mlx5_txq.c > @@ -566,8 +566,8 @@ mlx5_txq_ibv_new(struct rte_eth_dev *dev, uint16_t id= x) > txq_uar_init(txq_ctrl); > if (qp.comp_mask & MLX5DV_QP_MASK_UAR_MMAP_OFFSET) { > txq_ctrl->uar_mmap_offset =3D qp.uar_mmap_offset; > - DRV_LOG(DEBUG, "port %u: uar_mmap_offset 0x%lx", > - dev->data->port_id, txq_ctrl->uar_mmap_offset); > + DRV_LOG(DEBUG, "port %u: uar_mmap_offset 0x%x", > + dev->data->port_id, (int)(txq_ctrl->uar_mmap_offset)); > } else { > DRV_LOG(ERR, > "port %u failed to retrieve UAR info, invalid" > --=20 > 2.12.0 >=20