From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DBCFA0540; Mon, 13 Jul 2020 12:39:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B773D1D5FF; Mon, 13 Jul 2020 12:39:06 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id EABB71D5FB for ; Mon, 13 Jul 2020 12:39:04 +0200 (CEST) IronPort-SDR: WW7sljsZeaZ74EF/c4/vheqA36hHU8eJq1MHXd8ok0fWyWzzdAGZYC/sb3lBcEapmlp3c0nw45 B5TES/6gzQPg== X-IronPort-AV: E=McAfee;i="6000,8403,9680"; a="166698739" X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="166698739" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 03:39:04 -0700 IronPort-SDR: qA1oSqDWBuiCXAXPi8LnnUerj7oTqa4F5xSe81d5Iob+7W1t1SRDbVlewMXw63C7JMnUTpcQzT XLn/BYwjIniw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="390140025" Received: from vmedvedk-mobl.ger.corp.intel.com (HELO [10.213.224.143]) ([10.213.224.143]) by fmsmga001.fm.intel.com with ESMTP; 13 Jul 2020 03:39:02 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com, david.marchand@redhat.com, jerinj@marvell.com, mdr@ashroe.eu References: <6874799.X9nVCTG8Yq@thomas> <87399890-4cd0-e102-2072-f5d6a12ffde9@intel.com> <3373632.pBHoEykVWN@thomas> From: "Medvedkin, Vladimir" Message-ID: <10c4b826-fdff-c16c-96d2-d792b6e25c7d@intel.com> Date: Mon, 13 Jul 2020 11:39:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <3373632.pBHoEykVWN@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 1/8] eal/x86: introduce AVX 512-bit type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 13/07/2020 11:25, Thomas Monjalon wrote: > 13/07/2020 12:23, Medvedkin, Vladimir: >> Hi Thomas, >> >> On 10/07/2020 22:49, Thomas Monjalon wrote: >>> Please Cc those who participated in the review previously. >>> Adding Ray, Jerin, David. >>> >>> 10/07/2020 16:46, Vladimir Medvedkin: >>>> + __m512i z; >>>> + ymm_t y[RTE_X86_ZMM_SIZE / sizeof(ymm_t)]; >>>> + xmm_t x[RTE_X86_ZMM_SIZE / sizeof(xmm_t)]; >>>> + uint8_t u8[RTE_X86_ZMM_SIZE / sizeof(uint8_t)]; >>>> + uint16_t u16[RTE_X86_ZMM_SIZE / sizeof(uint16_t)]; >>>> + uint32_t u32[RTE_X86_ZMM_SIZE / sizeof(uint32_t)]; >>>> + uint64_t u64[RTE_X86_ZMM_SIZE / sizeof(uint64_t)]; >>>> + double pd[RTE_X86_ZMM_SIZE / sizeof(double)]; >>>> +} __rte_aligned(RTE_X86_ZMM_SIZE) __rte_x86_zmm_t; >>>> + >>>> +#endif /* __AVX512F__ */ >>> >>> You were supposed to undef the macros above. >> >> It was intentional. It could be used later by other libs, like XMM_SIZE: >> git grep -lw XMM_SIZE >> lib/librte_acl/acl_gen.c >> lib/librte_acl/acl_run.h >> lib/librte_acl/rte_acl.h >> lib/librte_eal/arm/include/rte_vect.h >> lib/librte_eal/ppc/include/rte_vect.h >> lib/librte_eal/x86/include/rte_vect.h >> lib/librte_hash/rte_thash.h > > OK. Was it agreed with David to NOT undef? > I may have missed this part. > As I can understand David had no objections to export it. I think it could be useful for some libs to have those macros. Please correct me if I'm wrong. > -- Regards, Vladimir