From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 031F2A00C3; Mon, 3 Oct 2022 15:59:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E29E740DFB; Mon, 3 Oct 2022 15:59:27 +0200 (CEST) Received: from guvercin.ceng.metu.edu.tr (guvercin.ceng.metu.edu.tr [144.122.171.43]) by mails.dpdk.org (Postfix) with ESMTP id 65ABC40695 for ; Mon, 3 Oct 2022 15:59:26 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by guvercin.ceng.metu.edu.tr (Postfix) with ESMTP id 204112C171; Mon, 3 Oct 2022 16:59:26 +0300 (+03) X-Virus-Scanned: Debian amavisd-new at ceng.metu.edu.tr Received: from guvercin.ceng.metu.edu.tr ([127.0.0.1]) by localhost (guvercin.ceng.metu.edu.tr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xbQtEv-niGxT; Mon, 3 Oct 2022 16:59:20 +0300 (+03) Received: from roundcube.ceng.metu.edu.tr (kanarya.ceng.metu.edu.tr [144.122.171.33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: e1885458) by guvercin.ceng.metu.edu.tr (Postfix) with ESMTPSA id D5A5F2C110; Mon, 3 Oct 2022 16:59:18 +0300 (+03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ceng.metu.edu.tr; s=mail; t=1664805560; bh=vIkltTi/3dhPODpVp2MfnHMNXyuWQX8f4QyRpsDRpEs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JFtJy/4SmTiOE/zXacULAT6d4CdPXlLdY6QUZVu47bSwrNzdgLx7oCLJKxDQYmvkU Chps3pbAud2Uqt2KJVpk9N0mIVkzCd0pAbOccwT/rvFazPCF8bvrd34kHa2Nhgx2sR Zeq1/YWWvo8VRAJT/W3l7mVQtI78dNaLltBmF9Ww= MIME-Version: 1.0 Date: Mon, 03 Oct 2022 16:59:18 +0300 From: Omer Yamac To: Bruce Richardson Cc: dev@dpdk.org, ferruh.yigit@amd.com Subject: Re: [PATCH] drivers: suggestion on removing empty version.map files In-Reply-To: References: <20221003065203.555038-1-omer.yamac@ceng.metu.edu.tr> User-Agent: Roundcube Webmail Message-ID: <10e1b3c74bbaba4bcca8fadcddf8a7a4@ceng.metu.edu.tr> X-Sender: omer.yamac@ceng.metu.edu.tr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 03.10.2022 12:19, Bruce Richardson wrote: > On Mon, Oct 03, 2022 at 09:52:03AM +0300, Abdullah Ömer Yamaç wrote: >> In this patch, we remove all version.map files which include >> only the below part: >> `DPDK_23 { >> local: *; >> };` >> >> Then we modify the meson.build to be able to compile without >> version.map >> >> Signed-off-by: Abdullah Ömer Yamaç >> Suggested-by: Ferruh Yigit >> --- > > I think you need to flag this as depending on us bumping the meson > version > requirement up to 0.53 as has been proposed. This doesn't work with > 0.4x > versions. > Thanks for your warnings. Instead of using fs module, I will use python script that checks file exist or not. If it is okay, I will resubmit the patch. > One other suggestion is to split this into 2 patches. Have the first > patch > just with the meson changes to support this, and the second patch then > doing the actual removal. That would make this a lot easier to review > since > the code needing the review will all be in the first patch. > I will do in the next patch. > Otherwise, good idea! > > Regards, > /Bruce Thanks