From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B95DA0C41; Thu, 16 Sep 2021 19:16:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E43C4069E; Thu, 16 Sep 2021 19:16:20 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id D9D4A4003F for ; Thu, 16 Sep 2021 19:16:17 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10109"; a="209849404" X-IronPort-AV: E=Sophos;i="5.85,299,1624345200"; d="scan'208";a="209849404" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2021 10:16:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,299,1624345200"; d="scan'208";a="452999327" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga002.jf.intel.com with ESMTP; 16 Sep 2021 10:15:59 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 16 Sep 2021 10:15:59 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 16 Sep 2021 10:15:58 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 16 Sep 2021 10:15:58 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 16 Sep 2021 10:15:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UF7v5Z9AdeVc9aBws0+fJhYYnMFO9Wgsunm0Z8o95Mw0nd5M+RjGSuDaXF05xMnhmu+yEezOrAjyPjAE0uy5SRaICXXfm0bp1+EVbg4p/egiscnRgiQpjDRxY/J96y2sB6dh8kINv/8hfRFsNChDzLa5BrL1es7PGWMfjO6qPPqBYweqFw8pef2eK/y+3+t9R2FRoC+/VdRAv81UEoCWcwGwZVWfA/+Eo/2dcFt6FYfxNuLztxeYy30OFX4TeCQKSO9n4wd+CuQnE36vkHjPNZ6EXZIMfw8VTK9PEk5bTyKBjpgcgEcvrv/VX56wpWMmfCHt6CCF0hF/rK9ltq4jfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vVShObrM0CdULAjws3fjpRyOuFB+PEMYWHplyMDhqW4=; b=IrpzxH9aNPTy+WwuwfRA8h98B2N+iMwJICzETX03gFRMteRt3DlEvzZpj/1BfSd3rkoD8+oucX1juUsunU8MdWeBQUlFwyJFXidOwOefY6iQSb/FmTy0BxX/kK+Sl+u7Psn3zXqKyA7L9bzSEsaD6T2QD7vscimCCThhnShEihHP7QfZOvkDtSLTp8j7oOQm2ancF55XxPafhLggNjqj3rCy6ODfszfpyjBeOtlbOyLOVc97TKOF4ZCoKS5Nfssas4L9GR7v7HxvricO5RIHNdsoACAQRCbf3p7UYW+srK6lr/dmdB6Huhun972UmhAwChlfF/TDNLw8/KKmNypBVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vVShObrM0CdULAjws3fjpRyOuFB+PEMYWHplyMDhqW4=; b=g2d5l78IhuIqT1FNAXJkiTj0PCbA59kau5hTKxKeuizzD/zhSsm4JczLkrweRWTGdIVQAmgM5WpoQJGjq9n+5vweQ2O74hVYGxS6LeV0SOweW4/goaFFKn2vpH6ARqyH9zTMAWHBWHaQvH1NUafta2BXDv4RSMgIprG1hAa64Sc= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4839.namprd11.prod.outlook.com (2603:10b6:510:42::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Thu, 16 Sep 2021 17:15:54 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4523.016; Thu, 16 Sep 2021 17:15:53 +0000 To: CC: Jiawen Wu , , Bruce Richardson , Thomas Monjalon , "David Marchand" , Akhil Goyal References: <20210908083758.312055-1-jiawenwu@trustnetic.com> <20210908083758.312055-29-jiawenwu@trustnetic.com> <6624b581-e094-f704-be3d-745a04f9a771@oss.nxp.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <10fb40d3-250b-73d6-5288-4b810aec8621@intel.com> Date: Thu, 16 Sep 2021 18:15:48 +0100 In-Reply-To: <6624b581-e094-f704-be3d-745a04f9a771@oss.nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB3PR08CA0008.eurprd08.prod.outlook.com (2603:10a6:8::21) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB3PR08CA0008.eurprd08.prod.outlook.com (2603:10a6:8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Thu, 16 Sep 2021 17:15:52 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bfa9fda6-88ab-4651-02ab-08d97935a3ae X-MS-TrafficTypeDiagnostic: PH0PR11MB4839: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HeokqBWhFlLP7qhmwt2WkT1S0vM7Vzoldgxwtzs+gWg58sMU1QNH9REAkXccicHYCSxIBSbGEWWCzVxb5HZuoeKSNui9WTTfv5q7As5cJXdX1ZFC3p0cjQzD8y+ZxNPVE4mLjjnF3kGJHP0xrdRtQYppWy5Tgjfmk6xOJrWRdyfvbOxysaCWPCis5+mfxarqcHGO0omDlWMEZgfuOrCSquQVHgfPwb8FjR5/dBODwG97A2oAdqSAQaHUP2Tzu2tYV7y7Hacr31w7RiUou/m/6/BCD/ZjSHvgOckbnz3Wxt/YvUMA9GlVq35VlX3OMcxjKVimTQa5R3mWf6lsnaA+IVKhTmu4hrhSP+FXZkZfo7rTtu6lVH5MfTfq5pl82PnY+zRp/ulN7AMBX7cz2mBZVjpN9RO+ayyyk8slyOqw3vyDLCpS1YqIeyZuT6HpQxWrnUayx9lwK1KwT40cn/qk4zk0pj6SUf3lJpSHhAMD+6Ex51acEtZ45PjeDphkAQDJ5KMnwwJQzsoU0AfNXkIYdrmW5KKhpY49plpLLQeIePFXJNRRiwQsvVd8FcUqRbKUk2DIxgfyARgUUR14l+XC+xGIlSJ57v8lAqzDu+BHrXnVbEHjaCqjpBwfJvLcx597/fNdBQMqGlj4U9tpAcghNOSE/hKNar4BIRDLSXTOyNHDUGqKQ7xF2kEsadnrvgEJV0mwYlFA/JK0oe35VW5Ymw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(316002)(66556008)(8936002)(31686004)(16576012)(66946007)(54906003)(508600001)(38100700002)(6666004)(2906002)(956004)(2616005)(8676002)(31696002)(66476007)(53546011)(5660300002)(26005)(36756003)(83380400001)(186003)(6486002)(4326008)(44832011)(6916009)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?emMySmppN2FDZzVscjd0WkZseU4rL1ptTGJWbXJkV3p4Z050QjU1S1hPbXRQ?= =?utf-8?B?WVpkUjd5Vjl2TVlMSnE5ZnlWc0JINHVvMnpmUzkxU0dEQ2x4RStKM1NrQ21x?= =?utf-8?B?UkE3MU9IaHVYQ1g2R3BJcG1ER3V6VnA2QkZreE00eEVEd004TWRieTJHN3FB?= =?utf-8?B?UGVJZjFuNHNURGVtMWVRaUpaRUppdlErYTlhWGFiZUIvck41d0haRDJJM2xq?= =?utf-8?B?VXcvRGd4UmR5NWhOL2wrYm1ldU1iLzV4ZEd0dnI5RGdGaGt3OEJrUDNXSmlO?= =?utf-8?B?aFVWQWdTMVJLb3F3cHJ3Yld3Y25SaFRlUVI3MDd3ek1DVzNhSWhzdUV4N3ZT?= =?utf-8?B?UVdxZ29UWHdTUkJRQmRmOHg4QkZSZU5rU1R4VlFxQWx3UmFNRkpqaWk0UDZu?= =?utf-8?B?UXQzckNHVkUyQkRySjNmd1pYZ014aEVBRU1pRFF1cFVuS0pnUXNIYXlOUU9I?= =?utf-8?B?aGJnT1l5WW01UVZtNTNqWWJjOVhoOThLMXBqaW0xeXY5S01SL2tITWdZMkNI?= =?utf-8?B?bWtsYWpyVE1tZ09xdE5oYUtzYzR5TDBkaDNDNXh3QzNrYWt6SmExRmdRb25Y?= =?utf-8?B?M0E4VHB5M0c2dmRPaVlLUG1lZ1JuZklOUjZrSGpvLzdYVC8rME1xVGFpdWIw?= =?utf-8?B?RmwrTUpxUUJUK096ajJOMkpGK2x3ZGhzZTI5VWF4UkpaN01nemdtYktSdkNy?= =?utf-8?B?ZmtHaGdvVWJJaWcrbjdRZ3VIQzJzUWhkRllnYVNZK3RPTE51WWZtRlZEVGFV?= =?utf-8?B?VDV3bjQ1RWN3M0lQVDVhMjIzQ3lWRHJwN09OUFNKa2tXV3FxSWhrVDBwTlpy?= =?utf-8?B?R0dwQXJmc3UzY0Y2bThiU1l0OGw2ZFRPM1FYRVJhUGFIb0RMSnNSb0xDS2Iy?= =?utf-8?B?UDlOblROeWRmeEJEUlNVOGVoSkVjT2xDVFJzbzRyLzdJZFlkbFZCOHhTeWg1?= =?utf-8?B?ZVhhRHl1Vm1MN25obUl3amtCZ1QwOExXUC9pZy83YTE1RnZjQmozTEdHQVFT?= =?utf-8?B?NWpZSmFHYXF5bUcxSVpEQkFJYTNTa2ZSMWtqSjB1UjZQKy80ZkMyQ0JwUG9a?= =?utf-8?B?b1dSbklsR3NjTUZwVFJBMnhId2txNWpGWG9mWnM0R2NkZDVKdXM3ZHVmQjVs?= =?utf-8?B?dzJOV3ZHalUzWFhOU282dmNtMG1MVlBYdkkyVGYrMmdwRTdIKzJneFRBZHJZ?= =?utf-8?B?NkRaaEk2bERJNHVPWEp1aGJoRHN6d2Z6ZzkrVnY0aHZlRTBNL2l6ZHBmREtM?= =?utf-8?B?M09VdUljRnRaZkRtU21KRmJ6V0pqdEY5ZEpFYmkwTlM3QmZncHd4UHlwcGVF?= =?utf-8?B?Mk9MOUFQdXYyaGlIdTJPd1IrTTdWaU5LdXdDazlTTU1XeUFCUHZwTm9HdTNF?= =?utf-8?B?dWE3TjFZeUltcFM0TFQxREVlaE5VaUFlVHlIdENsejFSdXJXNTdCTVNFS3Aw?= =?utf-8?B?TjVxMjFiR2tpTkdzL1hhWnlZZk1RZGdDWXd0bUo1RDUvekR6ZzRwT2Zsdng0?= =?utf-8?B?VEF6bFB6TlVkTjNvcmVhZWcrcTBIK2s2K0tXOHJXb25jb2xtYjRkTEtUZUd3?= =?utf-8?B?RXpJUTZhZ0RkRHd1SVJXbFdkdVgwdkVDQ2ZRQ3V5cGRCZ1VQenFXdnByR2RP?= =?utf-8?B?emtock9KUVR6WmMrUkVFSHY1U0lwT01RQmJMd2QwTnBjSFNURzFobkRuSDMw?= =?utf-8?B?emN6Y3YxWFJrQ0owbVdHdC80QlNZT2RVRVcvSlZBcjZFUHBvVmtGWnNGMzJt?= =?utf-8?Q?xJbbUOkbbLT7imGp/i3Zzv1LPkBcxi222EF9Gq9?= X-MS-Exchange-CrossTenant-Network-Message-Id: bfa9fda6-88ab-4651-02ab-08d97935a3ae X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2021 17:15:53.8124 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fD4a8bTIksxqxXyWkT7+4l4+Mfb51SUilJH5XXEjyZ/BzRkULkd3Q5oT8K02ptJRaEkyajCXljI89c/Z908Y5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4839 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 28/32] net/ngbe: add IPsec context creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/16/2021 10:00 AM, Hemant Agrawal wrote: > > On 9/15/2021 10:28 PM, Ferruh Yigit wrote: >> On 9/8/2021 9:37 AM, Jiawen Wu wrote: >>> Initialize securiry context, and support to get security >>> capabilities. >>> >>> Signed-off-by: Jiawen Wu >> <...> >> >>> --- a/drivers/net/ngbe/ngbe_ethdev.c >>> +++ b/drivers/net/ngbe/ngbe_ethdev.c >>> @@ -430,6 +430,12 @@ eth_ngbe_dev_init(struct rte_eth_dev *eth_dev, void >>> *init_params __rte_unused) >>>       /* Unlock any pending hardware semaphore */ >>>       ngbe_swfw_lock_reset(hw); >>>   +#ifdef RTE_LIB_SECURITY >>> +    /* Initialize security_ctx only for primary process*/ >>> +    if (ngbe_ipsec_ctx_create(eth_dev)) >>> +        return -ENOMEM; >>> +#endif >> Hi Hemant, >> >> I see 'RTE_LIB_SECURITY' is still used in some PMDs, as this new PMD also uses >> it? >> Previously I assume this macro was to mark that security library is enabled, is >> this macro still valid? Who should set this macro now? >> >> Also can you please help reviewing this and next a few patches since they are >> related to the security? > > Hi Ferruh, > >      It indicate if the driver is using SECURITY library functions. In Ethernet > driver, it typically means the inline security offload. > Got it, but right now who sets this macro? It isn't set automatically when security library is enabled/compiled, right? > Ok, I will try to review. > > > regards, > > Hemant > >>