From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 39AD61B29F; Tue, 13 Feb 2018 09:53:19 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 04D6E40FB63E; Tue, 13 Feb 2018 08:53:18 +0000 (UTC) Received: from [10.36.112.39] (ovpn-112-39.ams2.redhat.com [10.36.112.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0FA1F2026DFD; Tue, 13 Feb 2018 08:53:12 +0000 (UTC) From: Maxime Coquelin To: tiwei.bie@intel.com, yliu@fridaylinux.org, ferruh.yigit@intel.com, victork@redhat.com, thomas@monjalon.net, olivier.matz@6wind.com, jianfeng.tan@intel.com Cc: dev@dpdk.org, stable@dpdk.org, zhihong.wang@intel.com, qian.q.xu@intel.com, lei.a.yao@intel.com References: <20180212154612.5297-1-maxime.coquelin@redhat.com> <20180212154612.5297-2-maxime.coquelin@redhat.com> Message-ID: <1102a5a0-dc78-89ec-2a48-10253ae048ed@redhat.com> Date: Tue, 13 Feb 2018 09:53:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180212154612.5297-2-maxime.coquelin@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 13 Feb 2018 08:53:18 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 13 Feb 2018 08:53:18 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v2 1/3] net/virtio: fix mbuf data offset for simple Rx function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 08:53:19 -0000 On 02/12/2018 04:46 PM, Maxime Coquelin wrote: > From: Olivier Matz > > The mbuf->data_off was was not properly set for the first received > mbufs. Fix this by setting it in virtqueue_enqueue_recv_refill_simple(), > which is used to enqueue the first mbuf in the ring. > > The function virtio_rxq_rearm_vec(), which is used to rearm the ring > with new mbufs, is valid and does not need to be updated. > > Fixes: cab0461234e7 ("virtio: fill Rx avail ring with blank mbufs") > Cc: stable@dpdk.org > > Signed-off-by: Olivier Matz > --- > drivers/net/virtio/virtio_rxtx_simple.c | 1 + > 1 file changed, 1 insertion(+) > I forgot to apply my r-b when re-posting: Reviewed-by: Maxime Coquelin Maxime