From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id B59E1239 for ; Sat, 26 May 2018 11:32:58 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EF94C21AAD; Sat, 26 May 2018 05:32:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 26 May 2018 05:32:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=+HFMgtzaV40ejJNQltLT57Cvli rFVskh/RxR16V0src=; b=aom2ICGcfRrt+cx065C2YLTi8ntG5HIJZLCK2PAdTE 9xGLKW7VNNP5BZnk4PO9Z+Yf47j86aL7mg/LKHzcaDhkAFJoCqKNxOgVx7BESDlx uIw/qLPyAX7QJWEzSnwPEVouM0pXGNf3Y1dY2lgaai5CgwDqlNe8+S4UqiJ5ehJD k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=+HFMgt zaV40ejJNQltLT57CvlirFVskh/RxR16V0src=; b=jZ9DC2fQr+Ce1jA9J/vzRM SmXnnCTvCsrlt3YGfMuKTK7KJv3zpv3H1c4VxcM/+7EYi8Fxz7s+koEY8RBTcYDv o7Mt0ix7MTDmWVei/GoaMzde+lD3vsWURkJ/dsTSuiaK7Wih8Qng3SgbrQLDxeUl u76aWaNrwosoLV7Nc/pfgIFHiqKPI8+hMg/8GV367jM0vIBkWRAhBP5XObzfSJlM DURyB8ldNPlBtGj5D0MulsBwnNG4DhoQlemeiAYJsioXzDreYIoPzcfalt2P2eJa 0ClzIDvWXaoMRoojBfjJpSlYuJLMEa62jqiwkBzmisMEMHAqJmlZ2F7RNb390MUg == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (218.15.136.77.rev.sfr.net [77.136.15.218]) by mail.messagingengine.com (Postfix) with ESMTPA id 39625E43E8; Sat, 26 May 2018 05:32:55 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org Date: Sat, 26 May 2018 11:32:53 +0200 Message-ID: <11072939.itZiRipOQY@xps> In-Reply-To: <20180525151858.GA18500@bricha3-MOBL.ger.corp.intel.com> References: <20180424123255.204330-1-bruce.richardson@intel.com> <20180525145158.5113-1-thomas@monjalon.net> <20180525151858.GA18500@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] devtools: add test script for meson builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 May 2018 09:32:59 -0000 25/05/2018 17:18, Bruce Richardson: > On Fri, May 25, 2018 at 04:51:58PM +0200, Thomas Monjalon wrote: > > +default_path=$PATH > > + > > +# Load config options > > +. $(dirname $(readlink -e $0))/load-devel-config > > + > > Why is this needed here, it seems to be called before each individual > config anyway. Right, it can be removed from here. > > +reset_env () > > +{ > > + export PATH=$default_path > > + unset CROSS > > + unset ARMV8_CRYPTO_LIB_PATH > > + unset FLEXRAN_SDK > > + unset LIBMUSDK_PATH > > + unset LIBSSO_SNOW3G_PATH > > + unset LIBSSO_KASUMI_PATH > > + unset LIBSSO_ZUC_PATH > > + unset PQOS_INSTALL_PATH > > These variables bar PATH are unused by meson build, so should be removed > here to avoid giving the impression they are use. Actually they should be used when compiling. PATH can be used to allow a toolchain which is not in the standard path. And dependencies _PATH variables can be specified only for some builds. Example: I have libsso only for x86 64-bit, so I do not set it for 32-bit or ARM builds. The config file reads DPDK_TARGET to know. Note: DPDK_TARGET is not yet set correctly for every builds in this version. > $CROSS is used by the > script so perhaps it can be kept. However, the whole point of the > cross-files is that you include all the needed details of your compiler > there. I think we should move away from using the CROSS value completely, > and use the cross-files properly. Yes we can remove CROSS if it is redundant with config files in config/arm/. But I do not understand why these files cannot be agnostic regarding the name (CROSS) of the toolchain. To me it is very strange to have the binary names hard-linked in the configs. Anyway, this discussion is out of the scope of this script. So I am for removing the CROSS variable and use aarch64-linux-gnu-gcc as it is hard written in every ARM configs for now. > > +cd $(dirname $(readlink -m $0))/.. > > + > I don't think we should force the builds to be always put into the base > directory. Instead of using cd, I think we should instead capture the base > directory path and pass that to meson. OK to not force the directory. You want to build in the current directory? If yes, we can just remove this "cd" and no need to pass a base directory to meson. > > +load_config () > > +{ > > + reset_env > > + . $(dirname $(readlink -e $0))/load-devel-config > > + MESON=${MESON:-meson} > > +} > Why does this need to be done each time? Because the config could be different for each build (see above).