From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A104A058A; Fri, 17 Apr 2020 16:51:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3A9A81E93F; Fri, 17 Apr 2020 16:51:10 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 9F0CF1E91E for ; Fri, 17 Apr 2020 16:51:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587135068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=naeYzTq0eOO6WzkS8iUY/45/FGuGrhN4gdBl8Lt19ok=; b=OOot5PZoXzL/986TatQj2Z9ZEwF1H2+2gyKTK3zq3lGGvq/16Ibk7Tb5DT5n6hu8K17lPJ 8Y6K9sUK21QM62fVqnTDlKGY58//hrYdscehGxi04sr2DI6DLrdznxUp9JS/5/ONsSuJo5 MO2eoDJZ7VzP2UIRewbNplUKEs5xPmY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-214-QXV0Gu8_N22JXzZwMjXUAg-1; Fri, 17 Apr 2020 10:51:06 -0400 X-MC-Unique: QXV0Gu8_N22JXzZwMjXUAg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6A574DB60; Fri, 17 Apr 2020 14:51:03 +0000 (UTC) Received: from [10.33.36.201] (unknown [10.33.36.201]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D38319C70; Fri, 17 Apr 2020 14:50:55 +0000 (UTC) To: Thomas Monjalon , Bruce Richardson , konstantin.ananyev@intel.com Cc: dev@dpdk.org, Gavin.Hu@arm.com, ravi1.kumar@amd.com, g.singh@nxp.com, hemant.agrawal@nxp.com, akhil.goyal@nxp.com, johndale@cisco.com, hyonkim@cisco.com, jingjing.wu@intel.com, wenzhuo.lu@intel.com, rmody@marvell.com, shshaikh@marvell.com, matan@mellanox.com, shahafs@mellanox.com, declan.doherty@intel.com, cristian.dumitrescu@intel.com, zhihong.wang@intel.com, David Marchand References: <20200407162755.6802-1-ktraynor@redhat.com> <20200416184549.10747-1-ktraynor@redhat.com> <20200417093358.GB1701@bricha3-MOBL.ger.corp.intel.com> <3643335.9fHWaBTJ5E@thomas> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: <110dc2b9-02d8-1702-d496-b0b91b87451e@redhat.com> Date: Fri, 17 Apr 2020 15:50:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <3643335.9fHWaBTJ5E@thomas> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] x86/eal: gcc 10 ignore stringop-overflow warnings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 17/04/2020 11:13, Thomas Monjalon wrote: > 17/04/2020 11:33, Bruce Richardson: >> On Thu, Apr 16, 2020 at 07:45:49PM +0100, Kevin Traynor wrote: >>> stringop-overflow warns when it sees a possible overflow >>> in a string operation. >>> >>> In the rte_memcpy functions different branches are taken >>> depending on the size. stringop-overflow is raised for the >>> branches in the function where it sees the static size of the >>> src could be overflowed. >>> >>> However, in reality a correct size argument and in some cases >>> dynamic allocation would ensure that this does not happen. >>> >>> For example, in the case below for key, the correct path will be >>> chosen in rte_memcpy_generic at runtime based on the size argument >>> but as some paths in the function could lead to a cast to 32 bytes >>> a warning is raised. >>> >>> In function =E2=80=98_mm256_storeu_si256=E2=80=99, >>> inlined from =E2=80=98rte_memcpy_generic=E2=80=99 >>> at ../lib/librte_eal/common/include/arch/x86/rte_memcpy.h:315:2, >>> inlined from =E2=80=98iavf_configure_rss_key=E2=80=99 >>> at ../lib/librte_eal/common/include/arch/x86/rte_memcpy.h:869:10: >>> >>> /usr/lib/gcc/x86_64-redhat-linux/10/include/avxintrin.h:928:8: >>> warning: writing 32 bytes into a region of size 1 [-Wstringop-overflow= =3D] >>> 928 | *__P =3D __A; >>> | ~~~~~^~~~~ >>> In file included >>> from ../drivers/net/iavf/../../common/iavf/iavf_prototype.h:10, >>> from ../drivers/net/iavf/iavf.h:9, >>> from ../drivers/net/iavf/iavf_vchnl.c:22: >>> >>> ../drivers/net/iavf/iavf_vchnl.c: >>> In function =E2=80=98iavf_configure_rss_key=E2=80=99: >>> >>> ../drivers/net/iavf/../../common/iavf/virtchnl.h:508:5: >>> note: at offset 0 to object =E2=80=98key=E2=80=99 with size 1 declared = here >>> 508 | u8 key[1]; /* RSS hash key, packed bytes */ >>> | ^~~ >>> >>> Ignore the stringop-overflow warnings for rte_memcpy.h functions. >>> >>> Bugzilla ID: 394 >>> Bugzilla ID: 421 >>> >>> Signed-off-by: Kevin Traynor > [...] >>> --- a/lib/librte_eal/x86/include/rte_memcpy.h >>> +++ b/lib/librte_eal/x86/include/rte_memcpy.h >>> +#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >=3D 100000) >>> +#pragma GCC diagnostic ignored "-Wstringop-overflow" >>> +#endif >> >> Does this permanently need to be disabled for all compilation units >> including rte_memcpy.h, or can it be used with a push/pop set of pragmas= to >> only disable for the required functions? >=20 > Even better, isn't there a solution in memcpy code? >=20 >=20 There may be, it could do with fresh eyes - Bruce/Konstantin? In the meantime I will send a v3 with push/pop so it is available as an option.