* [PATCH] pipeline: fix validate header instruction
@ 2022-11-21 14:24 Cristian Dumitrescu
2022-11-22 12:32 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Cristian Dumitrescu @ 2022-11-21 14:24 UTC (permalink / raw)
To: dev; +Cc: Yogesh Jangra, stable
From: Yogesh Jangra <yogesh.jangra@intel.com>
The exported data structure for the header validate instruction did
not populate its struct_id field, which results in segmentation fault.
Fixes: 216bc906d00 ("pipeline: export pipeline instructions to file")
Cc: stable@dpdk.org
Signed-off-by: Yogesh Jangra <yogesh.jangra@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
lib/pipeline/rte_swx_pipeline.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/pipeline/rte_swx_pipeline.c b/lib/pipeline/rte_swx_pipeline.c
index 232dafb95e..0e631dea2b 100644
--- a/lib/pipeline/rte_swx_pipeline.c
+++ b/lib/pipeline/rte_swx_pipeline.c
@@ -11793,10 +11793,12 @@ instr_hdr_validate_export(struct instruction *instr, FILE *f)
"\t\t.type = %s,\n"
"\t\t.valid = {\n"
"\t\t\t.header_id = %u,\n"
+ "\t\t\t.struct_id = %u,\n"
"\t\t},\n"
"\t},\n",
instr_type_to_name(instr),
- instr->valid.header_id);
+ instr->valid.header_id,
+ instr->valid.struct_id);
}
static void
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] pipeline: fix validate header instruction
2022-11-21 14:24 [PATCH] pipeline: fix validate header instruction Cristian Dumitrescu
@ 2022-11-22 12:32 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2022-11-22 12:32 UTC (permalink / raw)
To: Cristian Dumitrescu; +Cc: dev, Yogesh Jangra, stable
21/11/2022 15:24, Cristian Dumitrescu:
> From: Yogesh Jangra <yogesh.jangra@intel.com>
>
> The exported data structure for the header validate instruction did
> not populate its struct_id field, which results in segmentation fault.
>
> Fixes: 216bc906d00 ("pipeline: export pipeline instructions to file")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yogesh Jangra <yogesh.jangra@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-22 12:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-21 14:24 [PATCH] pipeline: fix validate header instruction Cristian Dumitrescu
2022-11-22 12:32 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).