DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] vhost: fix mmap failure as len not aligned with hugepage size
Date: Tue, 24 Nov 2015 19:24:40 +0100	[thread overview]
Message-ID: <111424458.gvWv4ThTcC@xps13> (raw)
In-Reply-To: <1447308361-82139-1-git-send-email-jianfeng.tan@intel.com>

2015-11-12 14:06, Jianfeng Tan:
> This patch fixes a bug under lower version linux kernel, mmap()
> fails when length is not aligned with hugepage size. mmap()
> without flag of MAP_ANONYMOUS, should be called with length
> argument aligned with hugepagesz at older longterm version
> Linux, like 2.6.32 and 3.2.72, or mmap() will fail with EINVAL.
> This bug was fixed in Linux kernel by commit:
> dab2d3dc45ae7343216635d981d43637e1cb7d45
> To avoid failure, make sure in caller to keep length aligned.
> 
> v3 changes:
>  - fix (u64) -> (void *) convert error on 32-bit system
> 
> v2 changes:
>  - add Kernel version comments and commit msg
>  - remove unnecessary alignments when munmap
> 
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>

You forgot to keep Huawei's ack from v2.

Applied, thanks

  reply	other threads:[~2015-11-24 18:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11 22:04 [dpdk-dev] [PATCH v2] " Jianfeng Tan
2015-11-12  6:06 ` [dpdk-dev] [PATCH v3] " Jianfeng Tan
2015-11-24 18:24   ` Thomas Monjalon [this message]
2015-11-12  6:39 ` [dpdk-dev] [PATCH v2] " Xie, Huawei
2015-11-12 11:18 ` Thomas Monjalon
2015-11-12 12:51   ` Tan, Jianfeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=111424458.gvWv4ThTcC@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).