From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 360EBA00E6 for ; Mon, 8 Jul 2019 21:40:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1ED471B957; Mon, 8 Jul 2019 21:40:56 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id EE00E1B951 for ; Mon, 8 Jul 2019 21:40:53 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 44FC76E4; Mon, 8 Jul 2019 15:40:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 08 Jul 2019 15:40:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=GjcIINAMwuQn30+7mwiC1jUXNfomKDvUR24MoKAUusM=; b=VBQE5z/WoD7k 3Y0f5ZrgEWzRZNOAtB0i7Dioz4c1gBUsccykmVtgWTedczA8rPkYHFbJfq54ctQU P8xvNYnypwH+DcleXQB6iOVMtlQXHeGqd6I/zanVOBo0cKG9KPmNAgKA7X4Bk3sW KbvynHhxO+tc8Nx7x/h1XGTEFv+lRNU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=GjcIINAMwuQn30+7mwiC1jUXNfomKDvUR24MoKAUu sM=; b=fy7q+61izMhqdfQ21b8hnZ9f9GSVgcO/Ayzkof0lrL68UqypC68o+utqz Tk8yPxv1VT82aQR9RV0mZQBfU3zCdVdx1K0uXiL8dAY2mcuzfkci1TCqhqPBpxMD jgZs4NjZi+Fmb/i0kBAakB09jHuQn8AXSqppTZe9WrHhN0P7ohm4FBPt5BbdIoBD 3UMfRquuv6BpntfonXzcs+Y4vB0o1W0TpWhbRONbVVP6ViqzcSxxRoeOtWI42YQj 8EoQZ3+WdYPIg2+iZtWSwKbuQe8oleHITB8gNf5NzmxE8jCoQi8XTo4n1XFqru5L P+KxdQlNZowuRMyvq9jfGVChwDxLQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrgedtgddugeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D69E6380085; Mon, 8 Jul 2019 15:40:47 -0400 (EDT) From: Thomas Monjalon To: Hari Kumar Vemula Cc: dev@dpdk.org, reshma.pattan@intel.com, john.mcnamara@intel.com, marko.kovacevic@intel.com, jananeex.m.parthasarathy@intel.com, bruce.richardson@intel.com, aconole@redhat.com, david.marchand@redhat.com Date: Mon, 08 Jul 2019 21:40:44 +0200 Message-ID: <111637960.86sdBQFhhs@xps> In-Reply-To: <1559822385-21684-1-git-send-email-hari.kumarx.vemula@intel.com> References: <1549103306-9644-1-git-send-email-hari.kumarx.vemula@intel.com> <1559822385-21684-1-git-send-email-hari.kumarx.vemula@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6] doc: add meson ut info in prog guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi please find some comments below: 06/06/2019 13:59, Hari Kumar Vemula: > +++ b/doc/guides/prog_guide/meson_ut.rst > @@ -0,0 +1,151 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > + Useless blank line. > + Copyright(c) 2018-2019 Intel Corporation. > + > +.. _meson_unit_tests: Useless anchor. The doc can be referenced with :doc: links. > + > +Running DPDK Unit Tests with Meson > +================================== > + > +This section describes how to run testcases with the DPDK meson build system. Here and below, "testcases" should be split in two words. > + > + > +Building and running the unit tests > +----------------------------------- > + > +* Create the meson build output folder using the following command:: > + > + $ meson > + > +* Enter into build output folder, which was created by above command:: > + > + $ cd build Should be the same as above: > + > +* Compile DPDK using command:: > + > + $ ninja Do we really need to repeat above basic steps? Would be easier to just reference another guide about meson. I think doc/build-sdk-meson.txt should be moved to .rst. > + > +The output file of the build will be available in meson build folder. After > +a successful ninja command, the binary ``dpdk-test`` is created in > +``build/test/test/``. Again, "build" is an example directory. > + > +* Run the unit testcases:: > + > + $ ninja test > + # or > + $ meson test > + > +* To run specific test case via meson:: > + > + $ meson test > + # or > + $ ninja test Would be worth to mention why meson or ninja can be used. > + > + > +Grouping of testcases > +--------------------- > + > +Testcases have been grouped into four different groups based on conditions > +of time duration and performance of the individual testcase. Grouping has changed recently. This part should be updated please. > + > +* Fast tests which can be run in parallel. > +* Fast tests which must run serially. > +* Performance tests. > +* Driver tests. > +* Tests which produce lists of objects as output, and therefore that need > + manual checking. > + > +Testcases can be run in parallel or non-parallel mode using the ``is_parallel`` argument > +of ``test()`` in meson.build > + > +These tests can be run using the argument to ``meson test`` as > +``--suite project_name:label``. > + > +For example:: > + > + $ meson test --suite DPDK:fast-tests > + > + > +The project name is optional so the following is equivalent to the previous > +command:: > + > + > + $ meson test --suite fast-tests > + > + > +Running different test suites > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +The following commands are some examples of how to run testcases using option > +``--suite``: > + > +* Fast Tests should take less than 10 seconds. The meson command to run them > + is:: > + > + $ meson test --suite DPDK:fast-tests > + > +* Performance Tests should take less than 600 seconds. The meson command to > + run them is:: > + > + $ meson test --suite DPDK:perf-tests > + > +* Driver Tests should take less than 600 seconds. The meson command to run > + them is:: > + > + $ meson test --suite DPDK:driver-tests > + > +* The meson command to run Dump Tests is:: > + > + $ meson test --suite DPDK:dump-tests Would be simpler to just list the suites. > + > + > +Dealing with skipped testcases > +------------------------------ > + > +Some unit test cases have a dependency on external libraries, driver modules > +or config flags, without which the test cases cannot be run. Such test cases > +will be reported as skipped if they cannot run. To enable those test cases, > +the user should ensure the required dependencies are met. Below are a few > +possible causes why tests may be skipped and how they may be resolved: > + > +#. Optional external libraries are not found. > +#. Config flags for the dependent library are not enabled. > +#. Dependent driver modules are not installed on the system. > + > +To help find missing libraries, the user can specify addition search paths addition -> additional ? > +for those libraries as below: > + > +* Single path:: > + > + $ export LIBRARY_PATH=path > + > +* Multiple paths:: > + > + $ export LIBRARY_PATH=path1:path2:path3 > + > +Some functionality may be disabled due to library headers being missed as part > +of the build. To specify an additional search path for headers at > +configuration time, use one of the commands below: > + > +* Single path:: > + > + $ CFLAGS=-I/path meson build > + > +* Multiple paths:: > + > + $ CFLAGS=-I/path1 -I/path2 meson build Some quotes are missing to set multiple paths. > + > +Below are some examples that show how to export libraries and their header > +paths. > + > +To specify a single library at a time:: > + > + $ export LIBRARY_PATH=/root/wireless_libs/zuc/ > + $ CFLAGS=-I/root/wireless_libs/zuc/include meson build > + > +To specify multiple libraries at a time:: > + > + $ export LIBRARY_PATH=/path/zuc/:/path/libsso_kasumi/build/ > + $ CFLAGS=-I/path/zuc/include \ > + -I/path/libsso_kasumi/include \ > + meson build Why export is used for LIBRARY_PATH and not CFLAGS? I think both variables can be exported or prepend the meson command?