From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18016A0A03; Mon, 18 Jan 2021 18:51:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 966DD140D8E; Mon, 18 Jan 2021 18:51:17 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 5D8CB140D61 for ; Mon, 18 Jan 2021 18:51:16 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 9503153F; Mon, 18 Jan 2021 12:51:14 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 18 Jan 2021 12:51:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= 8qbUluToATaAOtCjrJg8cGvqAQoVWw4TpLVFb4V4E6I=; b=lAura35E7yXGzY3M hqft9EgFMdNh8f87zBnSN5IUId7GxsVLOOS+5+dWOb9IJfymJH4of0DDwDpBum2Y HbVs7DpXe59BcBBsBRI5WUA7wOoDSH9HmqVY8XIG482d3geRH5PWkg4qZj7gU7de f+tGo6vO96ioNjdhPMS9hbgMVIagp4o6UsOhVHfaJ2Oyg9ibm+TrZp1zW67kkfPR BhBzBVEjEcZa3msvpDoB57F9bGZPbYwyoTy9zkBD08zXSIoT0x8X7CAheDXP3T9d cRk/56RF3rliQjcblkM/0DIY8vRlAYFOwMr9c+k/YAmFrGl1ffqie583zB89XyLB WJWqQQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=8qbUluToATaAOtCjrJg8cGvqAQoVWw4TpLVFb4V4E 6I=; b=E1AetqdiR4TIOjqjcZDjA/qAgvj9j/2kszMqbvkU3Ih9rtkcSSyyjHLU/ SoAWmKtHLpJ+tV/abfAf5ny049MQshDmspD7jGyNgvxxGw0Ow+rJUQr1RkY9388d 6dQ8OmMH/7K2lSdEnxLjZwouYGdHlWC76VvWOKSPg7SaJexpLOHDpqQ9gEcBgUfo rZ5wGGs3eky5XD4lC39/rbtXl3aRqrbUZsYIs7JahcCgJ4F1h+5CxCtnBCnuPbMY W5+3Va36Yw6Gf19zOns7I1UCPyezia/hZc7/Y8iqW8EjzbTge9PhSLY93dJjRzxZ 4pJ8Fwx+LXximXvAes7MJWXtAjZxQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrtdekgddutdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B33E4240064; Mon, 18 Jan 2021 12:51:12 -0500 (EST) From: Thomas Monjalon To: Alexander Kozyrev Cc: dev@dpdk.org, viacheslavo@nvidia.com, orika@nvidia.com, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru, jerinjacobk@gmail.com Date: Mon, 18 Jan 2021 18:51:11 +0100 Message-ID: <11194524.VZjORZZNGx@thomas> In-Reply-To: <20210118161825.31516-2-akozyrev@nvidia.com> References: <20210116045054.14539-1-akozyrev@nvidia.com> <20210118161825.31516-1-akozyrev@nvidia.com> <20210118161825.31516-2-akozyrev@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 1/2] ethdev: introduce generic modify rte flow action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/01/2021 17:18, Alexander Kozyrev: > +/** > + * Field description for MODIFY_FIELD action. > + */ > +struct rte_flow_action_modify_data { > + enum rte_flow_field_id field; /**< Field ID */ more accurate: Field or memory type > + RTE_STD_C11 > + union { > + struct { > + uint32_t level; /**< Encapsulation level or tag index */ > + uint32_t offset; /**< Number of bits to skip from src */ "from src" only? I think we could use it for dst as well. I would remove "from src". > + }; > + uint64_t value; /**< Immediate value or memory address of it */ You should specify for RTE_FLOW_FIELD_POINTER and RTE_FLOW_FIELD_VALUE. Please add a dot at the end of each comment. [...] > +/** > + * @warning > + * @b EXPERIMENTAL: this structure may change without prior notice > + * > + * RTE_FLOW_ACTION_TYPE_MODIFY_FIELD > + * > + * Modifies a destination header field according to the specified s/Modifies/Modify/ (imperative form is preferred) > + * operation. Another packet field can be used as a source as well > + * as tag, mark, metadata, immediate value or a pointer to it. > + */ > +struct rte_flow_action_modify_field { > + enum rte_flow_modify_op operation; /**< Operation to perform on dst*/ > + struct rte_flow_action_modify_data dst; /**< Destination field */ > + struct rte_flow_action_modify_data src; /**< Source field */ > + uint32_t width; /**< Number of bits to use from a source field */ > +}; With above changes, Acked-by: Thomas Monjalon