From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 8463FC322 for ; Wed, 17 Feb 2016 23:51:56 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id a4so418528wme.1 for ; Wed, 17 Feb 2016 14:51:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=8sq3j8T+suluMrdVkD6yac/UzvMtgNev1PhStgpwkGQ=; b=bHURAvHFfJgzwix/ujykHCyEqEOh8MGSY6+Y6Jci0kBoTYj+2cdgcw7R9mlbH6OvIJ q1+sfD3HP6WBdlGNDM9/1rEg50WhkZwTVh7s/x9GR15UTl9NmkhpgH4Ipn2Y79st9JkE HZs90AVFjWCucj1tRmVJHWPTWItNwzScAkdLu0nm3/yqyXiSzKf/LqFmrTOarnz1ICKg /P8JmpGGkxC7p2Bpie7iPFOimodabxid+hxf5JmHZa6nq0nzKj+lECb7y7yOi2kpfpeE JxuckZerZ8JfYAhvSMca9jSiPR250a0+23R5y0oYun0Vo4EmgaOpacqqH59r3nYlnZ+/ 9lew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=8sq3j8T+suluMrdVkD6yac/UzvMtgNev1PhStgpwkGQ=; b=G41uSXmYO+IgFcUK1IokwkJ7CenwPZWk+wh4tdBO8l13zBOSATFyZhutMzPfwKtKBF 0ti5OSDUJgjKMGJXZNl2GK1soOyBPg6Su5OwbUP1oHGdNdoH9NGToO7jA94VeRi6cv1v C3MiYMrP/1L5y59ArhrAVGUDnS4W0jZ+ndTPE9OAdyJPlm0IxCsrDbYsIFDA9CrQIAE+ lp6jBv5ZF9Fl3RTgCW4w748Tu6GN9Nr+DSh71ZVk6ZVc6oIvLDt+hlYgdk3eu/EOv7Io M9L2MLzNAwLtr9ivQErtIhQXoSalnGhOhFByi+Aoj3DTUXJ9bb6Z5s7EDktXeiFQSr+a NQjA== X-Gm-Message-State: AG10YOS40wAoRgoi6qoTx+iYYEvvFw7ESrRRLhhw++5NdojuKswaQ4g3X9LL33PGJxO1lahv X-Received: by 10.194.90.77 with SMTP id bu13mr4271023wjb.60.1455749516345; Wed, 17 Feb 2016 14:51:56 -0800 (PST) Received: from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net. [82.235.116.147]) by smtp.gmail.com with ESMTPSA id q129sm56151wmd.14.2016.02.17.14.51.55 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 17 Feb 2016 14:51:55 -0800 (PST) From: Thomas Monjalon To: Yuanhan Liu Date: Wed, 17 Feb 2016 23:50:22 +0100 Message-ID: <111992201.GYQ3cgQmjX@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1449122773-25510-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1449122773-25510-1-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Victor Kaplansky , "Michael S. Tsirkin" Subject: Re: [dpdk-dev] [PATCH 0/5 for 2.3] vhost rxtx refactor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2016 22:51:56 -0000 Hi Yuanhan, 2015-12-03 14:06, Yuanhan Liu: > Vhost rxtx code is derived from vhost-switch example, which is very > likely the most messy code in DPDK. Unluckily, the move also brings > over the bad merits: twisted logic, bad comments. > > When I joined this team firstly, I was quite scared off by the messy > and long vhost rxtx code. While adding the vhost-user live migration > support, that I have to make fews changes to it, I then ventured to > look at it again, to understand it better, in the meantime, to see if > I can refactor it. > > And, here you go. There were several comments and a typo detected. Please what is the status of this patchset?