From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E77A7A0C47; Tue, 26 Oct 2021 10:33:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 755A141C23; Tue, 26 Oct 2021 10:33:14 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id A17C840E0F for ; Tue, 26 Oct 2021 10:33:13 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id EB54C5C02A6; Tue, 26 Oct 2021 04:33:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 26 Oct 2021 04:33:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= AZz5KhTtMXYvgzPwKc3wmFFArtbvEOd133NW31pYYWs=; b=qqII5SFlaY4AjecC +KRqmg9NdlNDaJHW0pao3XL99EYhBRZ4lrRvyVCwq/qE5m2bcSyFiWcB5jIL8x5X usQ/gdRXe8Cv8XAEADcnEEsysZOaUvUDcDFeaebe+rK16niInuvZd7fz7RB7wJE1 N/P5Ids/N4rd9oqBhF3Fimmyq2ZvJKgvltOJ6/8rDUseo1QNdbWgT4rO0KpuXwoE a1SJ7rqcAIpvUBKpJ7J8gfYSeLD6UhASNvDe6L5qjVKFWXyehZUgNuiNoh95Mhyy SRV/HrAr10LyW8r3X74eO6xr9AxIUVut+0eHbKeJrfP2Y91QDUhVyAda/KaaxW1g AuZ5fw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=AZz5KhTtMXYvgzPwKc3wmFFArtbvEOd133NW31pYY Ws=; b=GbrN519Jpgt6HavrAT/B33TFXbYF3JpVr4k1C15r4ePEufsYwhkoOLqhr Pml8zpI95ox+Qhxj6yal2r9dIR6MDINoaRU/Knb1bJxkRadR8YRegVxyR8kVG9Jb b9bQeed8885dfMINQgNdz/LZfPRBuH82x4H5DbUGyXrEsdfBxilcVjH/3Dn6xwhk XJsobIw5uV5ypJYF5oqhzCaXAhIrAh6DejsPV2Mcx6afsmUKnH7CcuQ4mckHtdir DrznPQFYwDVvpdABRyMHU247TVnUNcCDbhxeJLW8ceGwlucnq+Zz33g7CcoFE7Gj BPefQH59V4BzPHUoL7FzgP+M4sQzg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdefjedgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn rdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 26 Oct 2021 04:33:11 -0400 (EDT) From: Thomas Monjalon To: "Liguzinski, WojciechX" , "Singh, Jasvinder" , "Dumitrescu, Cristian" , "Liu, Yu Y" Cc: "dev@dpdk.org" , "Ajmera, Megha" , "Liu, Yu Y" , david.marchand@redhat.com Date: Tue, 26 Oct 2021 10:33:10 +0200 Message-ID: <11202335.JZDmDKIj46@thomas> In-Reply-To: References: <20211020075002.3871469-1-wojciechx.liguzinski@intel.com> <20211025113208.3910951-1-wojciechx.liguzinski@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v18 0/5] Add PIE support for HQoS library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/10/2021 10:24, Liu, Yu Y: > Hi Thomas, > > Would you merge this patch as the series is acked by Cristian as below? > https://patchwork.dpdk.org/project/dpdk/cover/20211019081902.3514841-1-wojciechx.liguzinski@intel.com/ I didn't see any email from Cristian. It seems you just added this ack silently at the bottom of the cover letter. 1/ an email from Cristian is far better 2/ when integrating ack, it must be done in patches, not cover letter > > Thanks & Regards, > Yu Liu > > -----Original Message----- > From: dev On Behalf Of Liguzinski, WojciechX > Sent: Monday, October 25, 2021 7:32 PM > To: dev@dpdk.org; Singh, Jasvinder ; Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [dpdk-dev] [PATCH v18 0/5] Add PIE support for HQoS library > > DPDK sched library is equipped with mechanism that secures it from the bufferbloat problem which is a situation when excess buffers in the network cause high latency and latency variation. Currently, it supports RED for active queue management. However, more advanced queue management is required to address this problem and provide desirable quality of service to users. > > This solution (RFC) proposes usage of new algorithm called "PIE" (Proportional Integral controller Enhanced) that can effectively and directly control queuing latency to address the bufferbloat problem. > > The implementation of mentioned functionality includes modification of existing and adding a new set of data structures to the library, adding PIE related APIs. > This affects structures in public API/ABI. That is why deprecation notice is going to be prepared and sent. > > Liguzinski, WojciechX (5): > sched: add PIE based congestion management > example/qos_sched: add PIE support > example/ip_pipeline: add PIE support > doc/guides/prog_guide: added PIE > app/test: add tests for PIE > > app/test/meson.build | 4 + > app/test/test_pie.c | 1065 ++++++++++++++++++ > config/rte_config.h | 1 - > doc/guides/prog_guide/glossary.rst | 3 + > doc/guides/prog_guide/qos_framework.rst | 64 +- > doc/guides/prog_guide/traffic_management.rst | 13 +- > drivers/net/softnic/rte_eth_softnic_tm.c | 6 +- > examples/ip_pipeline/tmgr.c | 142 +-- > examples/qos_sched/cfg_file.c | 127 ++- > examples/qos_sched/cfg_file.h | 5 + > examples/qos_sched/init.c | 27 +- > examples/qos_sched/main.h | 3 + > examples/qos_sched/profile.cfg | 196 ++-- > lib/sched/meson.build | 3 +- > lib/sched/rte_pie.c | 86 ++ > lib/sched/rte_pie.h | 398 +++++++ > lib/sched/rte_sched.c | 241 ++-- > lib/sched/rte_sched.h | 63 +- > lib/sched/version.map | 4 + > 19 files changed, 2172 insertions(+), 279 deletions(-) create mode 100644 app/test/test_pie.c create mode 100644 lib/sched/rte_pie.c create mode 100644 lib/sched/rte_pie.h > > -- > 2.25.1 > > Series-acked-by: Cristian Dumitrescu >