From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79A6442A94; Mon, 8 May 2023 12:44:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54E54410ED; Mon, 8 May 2023 12:44:12 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 3F0A040685 for ; Mon, 8 May 2023 12:44:10 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 605F93200928; Mon, 8 May 2023 06:44:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 08 May 2023 06:44:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1683542646; x=1683629046; bh=Qgu06SXGKlQdU+C9bnb0rytj9sr83v2f3Su Dr8OOhpw=; b=Pt+pUo/YgSrJuHVVbg/F0IrR4O8xUM7rNCKyQgGduqZBe3OWbik v+9c4lADAN/TZ5gxgSIP6nsh/JnCEjUXu+vR4y38d7yrM2oXyC0W6qeWgw1RA9dg psC2BW9u51pgMnehef9Q2QNDoIBf55LAdgfhrlNZmkizIY3boCQJgjQu+4C1TIwY cGAAwZSjTfa6krTk7c8g2LxryUEa0lm7cUOVILm7YEG7922nj7uJNgmBgYr55SB7 3VlMGS2vOi+UNcvbryufassncs+JmWERF3XWWz7RhryaNl6yup6ZOEN/0MduIHwH /eMCqVpnKrI9racQmQCbtlHwD5Z/K1FiILQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1683542646; x=1683629046; bh=Qgu06SXGKlQdU+C9bnb0rytj9sr83v2f3Su Dr8OOhpw=; b=H/aDo9Toitu3aHhbqUn5C6alYeyLu0RRqYTUWbnT6WXCbhFV1dh nJ3V9EuYbWWdGTB7OC8WfWQu9SPWpeoaW6P2IZzGQG+eaFcKj12DnRFxTHXHF/Fz rlK83ByNXPkF4P9/i0zs1Grc3Oo7DMdqDYhdvlzeZdk/UBsZSJVjl8ui2hUA3trg q1uzXy+Lez+JFEWpuUoLTHz8yWZB1CzGG5/yGNuP06M/nk53eOwQxrnWEe7jCKBA Yj9dj5DtpS2mTgTgNaWSaLAzDFRSoo8gd3MR/hP2FXR60L/rzZdRKA0W2U4YKA2N Ijnu9JGtr7iFhJrGlbmm94wx5naIlzZsFBw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefkedgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 8 May 2023 06:44:05 -0400 (EDT) From: Thomas Monjalon To: "Yigit, Ferruh" , "Gupta, Nipun" Cc: "dev@dpdk.org" , "david.marchand@redhat.com" , "Anand, Harpreet" , "Agarwal, Nikhil" Subject: Re: [PATCH v3 5/5] config/arm: add AMD CDX Date: Mon, 08 May 2023 12:44:04 +0200 Message-ID: <112237800.nniJfEyVGO@thomas> In-Reply-To: References: <20230124140746.594066-1-nipun.gupta@amd.com> <54328b0c-584e-dc58-2559-9d30e089a66a@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 08/05/2023 12:24, Gupta, Nipun: > From: Yigit, Ferruh > > On 4/21/2023 3:54 PM, Nipun Gupta wrote: > > > Adding support for AMD CDX devices > > > > > > Signed-off-by: Nipun Gupta > > > --- > > > config/arm/arm64_cdx_linux_gcc | 17 +++++++++++++++++ > > > config/arm/meson.build | 14 ++++++++++++++ > > > 2 files changed, 31 insertions(+) > > > create mode 100644 config/arm/arm64_cdx_linux_gcc > > > > > > diff --git a/config/arm/arm64_cdx_linux_gcc > > b/config/arm/arm64_cdx_linux_gcc > > > new file mode 100644 > > > index 0000000000..8e6d619dae > > > --- /dev/null > > > +++ b/config/arm/arm64_cdx_linux_gcc > > > @@ -0,0 +1,17 @@ > > > +[binaries] > > > +c = ['ccache', 'aarch64-linux-gnu-gcc'] > > > +cpp = ['ccache', 'aarch64-linux-gnu-g++'] > > > +ar = 'aarch64-linux-gnu-ar' > > > +as = 'aarch64-linux-gnu-as' > > > +strip = 'aarch64-linux-gnu-strip' > > > +pkgconfig = 'aarch64-linux-gnu-pkg-config' > > > +pcap-config = '' > > > + > > > +[host_machine] > > > +system = 'linux' > > > +cpu_family = 'aarch64' > > > +cpu = 'armv8-a' > > > +endian = 'little' > > > + > > > +[properties] > > > +platform = 'cdx' > > > diff --git a/config/arm/meson.build b/config/arm/meson.build > > > index 5213434ca4..39b8929534 100644 > > > --- a/config/arm/meson.build > > > +++ b/config/arm/meson.build > > > @@ -305,6 +305,18 @@ soc_bluefield = { > > > 'numa': false > > > } > > > > > > +soc_cdx = { > > > + 'description': 'AMD CDX', > > > + 'implementer': '0x41', > > > + 'part_number': '0xd42', > > > + 'flags': [ > > > + ['RTE_MACHINE', '"cdx"'], > > > + ['RTE_MAX_LCORE', 16], > > > + ['RTE_MAX_NUMA_NODES', 1] > > > + ], > > > + 'numa': false > > > +} > > > > Hi Nipun, > > > > Why we need a new arm platform/config? Is it because of above flags? > > If it can work with default values, I think we can drop this patch. > > Hi Ferruh, > > CDX driver works with generic ARM compilation too (arm64_armv8_linux_gcc). > > The versal platforms supporting CDX have A78 cores, and adding this cdx config > Helps to provide gcc option "march= armv8.4-a" which is for implementer > "0xd42" (ARM cortex A78 cores)., whereas for generic ARM compilation > "march= armv8-a". > > Maybe ARM guys can provide more information regarding if there is any impact > on using generic architecture flag (i.e. march= armv8a) on A78 cores. Please let's skip this patch for now. You should send it separately later, with perf testing and HW description in the commit log.