From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id D36B62C4B for <dev@dpdk.org>; Mon, 13 Feb 2017 19:02:57 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id 196so8227250wmm.1 for <dev@dpdk.org>; Mon, 13 Feb 2017 10:02:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=cd5GCdbsDfZOgbeAFXUhXwCEByQqh96iLByEgSJTRxY=; b=yNS7zffhz/tas3FFY+MPJME0GneF/Bm7inzFZ024lx5ngwy6pzm2z6T77o4bMHv1Uv 5f05In5TghfXz8z4tI6R9DgoILKzzVmKsHLAWZ2yirXv/TFJW2F8w86LGN99670pWF+R Boxlv+EcLXq4jE923ivQji6qcX5+b16BedrK8Rahk6OAP9fGk1qj2DYHDFFOjzez+YjV Y/98efw//Soy6w9/niTL7/0pWhDOfwK+ZOJHOYLBBXK4JmvrG9gLd2yUkpfJMZusmnxa 4JEnsK6FEWtt2eYM2/kluR6/C99oo6nSstlAtOCtHQeChMiqtX+zUGisS6k7PJL5kSRZ awLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=cd5GCdbsDfZOgbeAFXUhXwCEByQqh96iLByEgSJTRxY=; b=Co+R6QArM1ADEbyQZH8ehpDw4R5H9mDzCZNnUXZrcTJiF0JNz/DkON6BRfz3m4wdbl +bqfTqcdJNHm5wHd2KYQf0CbUMBPl7TYg8OSyJWguEEM7jtFQQr6qasryjgoFsSx3qgd cUPSBYix8itm9uAUkAfaZlDG8JeuBE644I4vgyrXP+PNfYC5pmqhOBB0oT6jziKYS0dJ jsCO2lmsqpu/CnEh8JLH9+yFmJ416tTHqVZQNSLNVRFiF6NA0/dehxXdropvdcKrbH76 SqKuP+vjnRmgps5yzw/KA/kgGeaGvtUFbgQot6O6TxSP7mVlxErGwpyl6MhJ5l6yH5pZ PDKg== X-Gm-Message-State: AMke39nb4xvlJHJCJMId8Nq9iFMyy6SToMsxU9PQj/TDs7FVGMs5A0CVUwazuwmfsBWzML56 X-Received: by 10.28.67.134 with SMTP id q128mr37873934wma.34.1487008977620; Mon, 13 Feb 2017 10:02:57 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id o22sm14809460wro.2.2017.02.13.10.02.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Feb 2017 10:02:57 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Yuanhan Liu <yuanhan.liu@linux.intel.com> Cc: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>, John McNamara <john.mcnamara@intel.com>, Ben Walker <benjamin.walker@intel.com> Date: Mon, 13 Feb 2017 19:02:56 +0100 Message-ID: <11273851.Pnx70jxc9N@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1485176682-12379-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1485176682-12379-1-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: announce API/ABI changes for vhost X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 13 Feb 2017 18:02:57 -0000 2017-01-23 21:04, Yuanhan Liu: > I made a vhost ABI/API refactoring at v16.04, meant to avoid such issue > forever. Well, apparently, I lied. > > People are looking for more vhost-user options now days, other than > vhost-user net only. For example, SPDK (Storage Performance Development > Kit) are looking for chance of vhost-user SCSI and vhost-user block. > > Apparently, they also need a vhost-user backend, while DPDK already > has a (mature enough) backend, they don't want to implement it again > from scratch. They want to leverage the one DPDK provides. > > However, the last refactoring hasn't done that right, at least it's > not friendly for extending vhost-user to add more devices support. > For example, different virtio devices has its own feature set, while > APIs like rte_vhost_feature_disable(feature_mask) have no option to > tell the device type. Thus, a more proper API should look like: > > rte_vhost_feature_disable(device_type, feature_mask); > > Besides that, few public files and structures should be renamed, to > not let it bind to virtio-net. Specifically, they are: > > - virtio_net_device_ops --> vhost_device_ops > - rte_virtio_net.h --> rte_vhost.h > > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>