From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EAA3A0A0C; Tue, 3 Aug 2021 15:18:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C030B411A7; Tue, 3 Aug 2021 15:18:26 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 9C5A540E3C; Tue, 3 Aug 2021 15:18:25 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 44B0E5C0108; Tue, 3 Aug 2021 09:18:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 03 Aug 2021 09:18:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 8cb8CELKMwymbj6On+6EllqziAgEh0m/paexEuyHLdI=; b=Inqeebsc56gXiABv xP7KPnY++9le0wZ7sNdVf9+xxNqB2JZq7RDAnezH8wRt1z+n5tiINLcB7NqF1BJY fH9Soa10QnZelr2ZEEjUzaQSW40rfgk3mnAa6aYniIkFHCtH+PPdb+9hmHf/TjPu svU0Ddfo85ISOzTrqV8xDGZBOXog/pzYmIjwNX1zEU4flOSMzgKqwVdJInd/+M1g HCcoc6I/9Kmmz8vsEnJTYeW6ZzgyCydKCjzgqEtYx24v8eJP0FInDle1O8u/fXot QGHSaSpEfixvYlCS8VRBrwapIpZG4yzeO4jVHw4OHqsZVMWzUOKrNcYTQ+YFg4Gz A6lE+Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=8cb8CELKMwymbj6On+6EllqziAgEh0m/paexEuyHL dI=; b=SczUYiFLXpG7yLoRgTS5DTgEIPfQARiPzvPJ4fx51P0Rj8AH4JP4iqX9Q d/YXg5Oq8tFLFyavXDAIvIeBk6JAbDAuCmJgXO2rZ6azlHuFcv3fDLtwsPHUQ6b+ QXm79zaTyMOSR10F8m61vwuzUNJI0JEv1+VlZ/qQei/F8nKGe4lonRNSrG+Y8qZ4 xZJIPVk5bvWcQ7xSTM8PDi8afG6oKizeA//9dYPjs9eMGzQ0e9ZHVBxrBK84RRk8 aC4tdAO2DEIMYqlCKK/wy9kmrEbo5RweAhP+TizmyzT9gupkuyzlUh5bTHEcJaFf rfJJ6qNd+g9EywyF3/lt41e6po0Rg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrieeggdeitdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 3 Aug 2021 09:18:24 -0400 (EDT) From: Thomas Monjalon To: Suanming Mou Cc: viacheslavo@nvidia.com, matan@nvidia.com, dev@dpdk.org, rasland@nvidia.com, stable@dpdk.org Date: Tue, 03 Aug 2021 15:18:22 +0200 Message-ID: <11307808.EMJHuiC2OS@thomas> In-Reply-To: <20210802143024.30484-1-suanmingm@nvidia.com> References: <20210802143024.30484-1-suanmingm@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/mlx5: workaround not supported drop action on the root table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/08/2021 16:30, Suanming Mou: > Currently, there are two types of drop action implementation > in the PMD. One is the DR(Direct Rules) dummy placeholder drop > action and another is the dedicated dummy queue drop action. > When creates flow on the root table with DR drop action, the > action will be converted to MLX5_IB_ATTR_CREATE_FLOW_FLAGS_DROP > Verbs attribute in rdma-core. > > In some inbox systems, MLX5_IB_ATTR_CREATE_FLOW_FLAGS_DROP Verbs > attribute may not be supported in the kernel driver. Create flow > with drop action on the root table will be failed as it is not > supported. In this case, the dummy queue drop action should be > used instead of DR dummy placeholder drop action. > > This commit adds the DR drop action support detect on the root > table. If MLX5_IB_ATTR_CREATE_FLOW_FLAGS_DROP Verbs is not > supported in the system, a dummy queue will be used as drop > action. > > Fixes: da845ae9d7c1 ("net/mlx5: fix drop action for Direct Rules/Verbs") > Cc: stable@dpdk.org > > Signed-off-by: Suanming Mou > Acked-by: Matan Azrad Applied, thanks.