From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 59ADAA052A;
Fri, 10 Jul 2020 23:25:18 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id CFBC41DAAA;
Fri, 10 Jul 2020 23:25:17 +0200 (CEST)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
[66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 5553D1DA6A
for <dev@dpdk.org>; Fri, 10 Jul 2020 23:25:16 +0200 (CEST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
by mailout.nyi.internal (Postfix) with ESMTP id CDBC95C012F;
Fri, 10 Jul 2020 17:25:15 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute7.internal (MEProxy); Fri, 10 Jul 2020 17:25:15 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm1; bh=
5gzb7G0nib/S2cShhs4TGkcgN0YiODKPBzLMOWfBRE0=; b=AWfz7a4LnQigLaYP
KpQ4b//qE+tG5D0K20+4RHx6qt+Bj8XLMDBynvfSxH8QD/HEG6O7D9pwoXs4lw7H
QWZJzIlOIgT0Rao0qnL+YbnGih8k/yYJalTZfFQv66bD/yHXmz1IMFkE8CoXVprV
2vH4wMsaMvRl8WCdSzHoWdWoR+owb/adteG0GE7ldZfFzvtS8eVxpLrX+kDjIhE7
1lGjPsYFrK8QI+5BygdqpbrClTUx5nldqtB3nHvyzz4Nf17Cay3iz4106Y219KZ7
2d6D3KfXy6g+NpMrI39VUCAzeGdYBv6Z4wu9cmxdPYIxWYrA8iInnQqUZxuCOgc4
qV01iA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm3; bh=5gzb7G0nib/S2cShhs4TGkcgN0YiODKPBzLMOWfBR
E0=; b=HPS1T1seTv+wGv4FV4x76GMEf6ZOZa39WGyRCQohPR85v69mKliM3mrqN
APZlpMHUExYOe1keMbOrO3yVzmYUwQQ4FYTVm1IiCxQ7n9QABg/SL5TDkIeAnTfm
GxPfCNkztbjXr6aT2Ec4/rS+384mZhXpd+MfRd3P7TD3mWsXXrpQ7f5E3lNkscqY
3Ag/q+QwVx8D9Vn8JPh+Vt6N3IRMahNx8SGhqoNQjhOdLGg7ZjGT7UbDmvkgRBOG
70iipZ+4EG2MbPSARsW/CVrxJ1POsGx7YkVuty6PxiWRTEyf6HHEbN3Ha8HY0iJI
U8EfYlnohtIBj/415bBdAC6a2lR9Q==
X-ME-Sender: <xms:u9wIX11EuJwveOw3abE7GVZq5d2LRBGKEPlSdrzZSOd_cU2GQ0L8TQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrvddugdduieehucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
ohhnrdhnvght
X-ME-Proxy: <xmx:u9wIX8HFkjtDIuKFKBGeRNDKR9Bjs1thGnIsINqjuVl7gBGYRHwZWQ>
<xmx:u9wIX17xdd5TjPD6yt96aRvJ1_J25-GGdbhYDNW1dTEZlZ_Y3GdAEg>
<xmx:u9wIXy2lnfquIhWtmQC-2VKdkvZjqURkCR8YEpk0Qpt_D2JkI6Lrkw>
<xmx:u9wIX9SC8ELtXiXk2aCw3RuiXJeYBbMjlE8FaYDyc2qgyxS-A-l6aw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id AC05230600B2;
Fri, 10 Jul 2020 17:25:14 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>, Tal Shnaiderman <talshn@mellanox.com>,
Ranjit Menon <ranjit.menon@intel.com>
Date: Fri, 10 Jul 2020 23:25:13 +0200
Message-ID: <11310226.gcHsNcSAOl@thomas>
In-Reply-To: <8b219c6c-7ad2-6987-ce59-13316bc7c223@intel.com>
References: <20200707202203.8780-1-dmitry.kozliuk@gmail.com>
<20200708214843.3080-1-dmitry.kozliuk@gmail.com>
<8b219c6c-7ad2-6987-ce59-13316bc7c223@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] eal/windows: detect insufficient
privileges for hugepages
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
09/07/2020 00:27, Ranjit Menon:
> On 7/8/2020 2:48 PM, Dmitry Kozlyuk wrote:
> > AdjustTokenPrivileges() succeeds even if no requested privileges have
> > been granted; this behavior is documented. Check last error code in
> > addition to return value to detect such case.
> >
> > Make error messages more specific and add troubleshooting hint.
> >
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
[...]
> > if (hugepage_claim_privilege() < 0) {
> > - RTE_LOG(ERR, EAL, "Cannot claim hugepage privilege\n");
> > + RTE_LOG(ERR, EAL, "Cannot claim hugepage privilege\n"
> > + "Verify that large-page support privilege "
> > + "is assigned to the current user\n");
The error message can be searched in the code,
so it is better not to break lines.
> Acked-by: Ranjit Menon <ranjit.menon@intel.com>
Applied with merged log lines, thanks.