From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D761DA00C2; Fri, 24 Apr 2020 18:13:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B13011D147; Fri, 24 Apr 2020 18:13:25 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E73731C439; Fri, 24 Apr 2020 18:13:23 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 41D525C0308; Fri, 24 Apr 2020 12:13:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Fri, 24 Apr 2020 12:13:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 3mMeYmBYETz4rxFil6hT4/G3eFfzfKCPuw+u/iV+9gE=; b=l7bx77gqHmab1RCi dBgv/CDjPPaTwXfWMuixJEmcSv2Evq/rSsBEtkdgbV8HdvdiS0j3rVnZSx0sfBl1 F9Y9610XhN1NaeT6aG7HTd09NaAipP+/8fvpknSsMbOe7+Ef7MJKAXUiYU7/olyv WtP48H5q0VzqCppy5ie7gZTu/gDQT6XkLauB7BA+ebbx6celkefpqK54CEzwESfs LI07Yjkbok9mRrx8E9+p7wjuyJ/2VwOjP29bppE1JSDJhuSRm9Jtc9Qka3jI3IjR Qh8B8whrR9zGcAMgMf+uCUrgX91r7X5GdCPd8HQqCVEuc0O/ehE405EuthLqaX8I akW2Mg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=3mMeYmBYETz4rxFil6hT4/G3eFfzfKCPuw+u/iV+9 gE=; b=r61VAtkIMiVXzFKVXM5xBPEJChcGxHg5d+nEoDt8Zj/RwlqgHHbITU1oG nLsQTshTwhA/LPp+BJT1t25YSrcY+OcLL0TWVigCbSy5VST0QX12jRcGvDWUPjKg 1BiIlNezu6biM+kAmvDa5ktf8UjceUYtZKxQQr/qf3LzFJ6TRB/lwQ7P22mARyOi 4GVWl8N+S4Q9yJ/LZphYDxPgMHN89S1OY9m/Hh1V9dZZKHQykxdWhFaaD3R4Cf8a tr6+RIs6FYQTDj7H2nsLyYa8VL75Ic0pk2DFJd9O+YWY82oZr5rx/kXgIsvPPhYp +Rt6YvYW+fwXkIrEm0gUaTo1gWb+g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrhedugdelfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepughllhdrnhhinhhjrgenucfkphepjeejrddufeegrddvtdefrddukeegnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrg hssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1AD473280068; Fri, 24 Apr 2020 12:13:22 -0400 (EDT) From: Thomas Monjalon To: Fady Bader Cc: dev@dpdk.org, stable@dpdk.org, olivier.matz@6wind.com, Andrew Rybchenko Date: Fri, 24 Apr 2020 18:13:21 +0200 Message-ID: <11342146.eQLIkvUDd3@thomas> In-Reply-To: References: <20200422073744.21804-1-fady@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] mempool: remove inline functions from export list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/04/2020 14:53, Andrew Rybchenko: > On 4/22/20 10:37 AM, Fady Bader wrote: > > The code didn't compile when using exported mempool functions under windows. > > > > compilation error logs: > > rte_mempool_exports.def : error LNK2001: > > unresolved external symbol rte_mempool_cache_flush > > rte_mempool_exports.def : error LNK2001: > > unresolved external symbol rte_mempool_default_cache > > rte_mempool_exports.def : error LNK2001: > > unresolved external symbol rte_mempool_generic_get > > rte_mempool_exports.def : error LNK2001: > > unresolved external symbol rte_mempool_generic_put > > lib\librte_mempool.dll.a : fatal error LNK1120: 4 unresolved externals > > clang: error: linker command failed with exit code 1120 (use -v to see invocation) > > [77/77] Linking target drivers/librte_bus_pci-0.200.2.dll. > > ninja: build stopped: subcommand failed. > > > > The cause was that there were some inline functions that were included > > in the export list. > > To solve this the functions were removed from rte_mempool_version.map > > export list which are implemented in the header and shouldn't be exported. > > > > Fixes: 4b5062755aa74517ed1d7bd ("mempool: allow user-owned cache") > > Fixes: 656f2d3ede96902202a1a5f ("mempool: deprecate specific get and put functions") > > Cc: stable@dpdk.org > > > > Signed-off-by: Fady Bader > > Acked-by: Andrew Rybchenko Applied, thanks