From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41])
 by dpdk.org (Postfix) with ESMTP id EE469C304
 for <dev@dpdk.org>; Sun, 29 Jan 2017 23:08:20 +0100 (CET)
Received: by mail-wm0-f41.google.com with SMTP id c85so189924858wmi.1
 for <dev@dpdk.org>; Sun, 29 Jan 2017 14:08:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=rkSeEEqEA99KZtLKPaUEoc2GtjQRh399gqyAtXRxC3k=;
 b=Cp7xYzwCWe6JP2VIKMt8hl02X2+UV6sCFnGk3M0Afa3TFEAPGjDfl8S5nkoMwf4iRF
 zMQFVrRowhZMSdWkSR+scQfuPWpPFAYMq8KYyzen8+K5quc1FIJ+YPuUMusyJV9yHXQR
 LLD3HPqf9H+4RiwEoeIxyYCsmJtqGuvfA12cEGbLoiTgQxf7avIueenS+cjK4TS91SJ8
 xEp4zvEOQgMFx8D7tU6ThhUpZx66b4KKm+dfTXTyAcaY05rxskmnnakogcp3PX2LE+Il
 BauJgFgH/A6z1eJd0SF6UDQ5WLl+Vw/iphAnevgQIld8e9EbNw69RYeiRrBodO4zEm8Y
 Ih7g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=rkSeEEqEA99KZtLKPaUEoc2GtjQRh399gqyAtXRxC3k=;
 b=c9yU8a1KSj36n4mxCldXWpJsSCtTbG4hjc/t/mtgStotsJ4O3eAznyJUYf32naz7ZG
 43aJoZ5wNy59u55GvGfTwNb1+sLW9PZHuesFfa5HP//X2jfazslZDuPxaPXfVzXAWDR0
 5pU2kf2sGgUA0ehFjRSS2+RsPQlR8ma3Cc/+eQjBvuxztu8qDrYTNTT0wSWFwZfhUCmF
 vY2soIbbN2JOdQ9FPEbQ2iT2q6fMPJ4cLuFC+Dm9HZY1jp5QyWHHVKhZzOu1aN/1/gR7
 4yntoIQCDgJyg1j/cuEFPrMIkWwXz0oFzIqz9yFIH3NoRCR1b1Wdk/1cDAN7wuxaqLwe
 YEPQ==
X-Gm-Message-State: AIkVDXLtITbX2iy2s1cIDfb29/DdvAEfeRVYA5AonYBnu+/JOkbYSlRJNQ7WW1q55x9Tyz8x
X-Received: by 10.28.69.17 with SMTP id s17mr12160624wma.60.1485727700711;
 Sun, 29 Jan 2017 14:08:20 -0800 (PST)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id e6sm19651666wrc.30.2017.01.29.14.08.19
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 29 Jan 2017 14:08:20 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Emmanuel Roullit <emmanuel.roullit@gmail.com>
Cc: dev@dpdk.org, "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
Date: Sun, 29 Jan 2017 23:08:19 +0100
Message-ID: <114310386.7azNsuM9Yc@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <20170124202202.31045-1-emmanuel.roullit@gmail.com>
References: <20170124202202.31045-1-emmanuel.roullit@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] eal: fail eal when no hugepages were found
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Jan 2017 22:08:21 -0000

2017-01-24 21:22, Emmanuel Roullit:
> Found with clang static analysis:
> lib/librte_eal/linuxapp/eal/eal_memory.c:1004:11:
> warning: Call to 'malloc' has an allocation size of 0 bytes
> tmp_hp = malloc(nr_hugepages * sizeof(struct hugepage_file));
>          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> The --no-huge case, where nr_hugepages would be 0
> as well, is handled earlier.
> 
> Fixes: 5e823a451261 ("ethdev: remove some VF functions")

This commit reference seems wrong. Please check