* [dpdk-dev] [PATCH] eal: fail eal when no hugepages were found
@ 2017-01-24 20:22 Emmanuel Roullit
2017-01-29 22:08 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Emmanuel Roullit @ 2017-01-24 20:22 UTC (permalink / raw)
To: david.marchand; +Cc: dev
Found with clang static analysis:
lib/librte_eal/linuxapp/eal/eal_memory.c:1004:11:
warning: Call to 'malloc' has an allocation size of 0 bytes
tmp_hp = malloc(nr_hugepages * sizeof(struct hugepage_file));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The --no-huge case, where nr_hugepages would be 0
as well, is handled earlier.
Fixes: 5e823a451261 ("ethdev: remove some VF functions")
Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
---
lib/librte_eal/linuxapp/eal/eal_memory.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c
index a956bb226..0b0355898 100644
--- a/lib/librte_eal/linuxapp/eal/eal_memory.c
+++ b/lib/librte_eal/linuxapp/eal/eal_memory.c
@@ -995,6 +995,9 @@ rte_eal_hugepage_init(void)
nr_hugepages += internal_config.hugepage_info[i].num_pages[0];
}
+ if (nr_hugepages == 0)
+ goto fail;
+
/*
* allocate a memory area for hugepage table.
* this isn't shared memory yet. due to the fact that we need some
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH] eal: fail eal when no hugepages were found
2017-01-24 20:22 [dpdk-dev] [PATCH] eal: fail eal when no hugepages were found Emmanuel Roullit
@ 2017-01-29 22:08 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2017-01-29 22:08 UTC (permalink / raw)
To: Emmanuel Roullit; +Cc: dev, Gonzalez Monroy, Sergio
2017-01-24 21:22, Emmanuel Roullit:
> Found with clang static analysis:
> lib/librte_eal/linuxapp/eal/eal_memory.c:1004:11:
> warning: Call to 'malloc' has an allocation size of 0 bytes
> tmp_hp = malloc(nr_hugepages * sizeof(struct hugepage_file));
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> The --no-huge case, where nr_hugepages would be 0
> as well, is handled earlier.
>
> Fixes: 5e823a451261 ("ethdev: remove some VF functions")
This commit reference seems wrong. Please check
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-29 22:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-24 20:22 [dpdk-dev] [PATCH] eal: fail eal when no hugepages were found Emmanuel Roullit
2017-01-29 22:08 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).