From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B378EA0C4B; Thu, 17 Jun 2021 17:41:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 39F1A4067A; Thu, 17 Jun 2021 17:41:40 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 2CCE340150 for ; Thu, 17 Jun 2021 17:41:39 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 5C15D5C0109; Thu, 17 Jun 2021 11:41:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 17 Jun 2021 11:41:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= ihNUl88CU+u3pJzzQKOmkK2wcp/c41xdadwXdXLuiTg=; b=uM4AArpEBVtL8ee6 FTllwC15pARcitJo6AedpLtYDuAjNcjHZGmIU9CnEdlySG8kUmxoVN03Hvgmu0To xhrEiK0to5Wj0aDHWrIYUQ8HjW+MNEmPLfig21PfG4waDcRMmC4z6tkHge5IAo72 fdUCNlCNJcm4qq0n6NYGithLh3EjeUv4f1BaFyBdlrQfhwfQY/kJOIHN+Y9ed/r1 Sy1wmnBauMyG2lDi/IazE81ToTyPJSYfrci9BSVxZIQ4kTRUcbHAhcAjPMACms7d aP61DkO9fSqf6YwYpewrQ3UC6hF1lAAVmqTL3DybgEUmfATEFvl7Sqpj0GsQ3DLI Igm70A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=ihNUl88CU+u3pJzzQKOmkK2wcp/c41xdadwXdXLui Tg=; b=Txk+FI3A5rPcwe2u/8Vy6eJvRZzlziLGbgGcH86gjwNlAsOBKXoexwXlK E0rkjfljH4RmMbYmjob1CgtwcR2pj66z3+MRrwZQXV4weK4MrqQLWBG7WH3KzuMx cLBFMG3doa914GdTeWVgajOjkXgktTNlrwE0ve31LaogMLZgzk4dJa3/cHyAou/I GkT/HHLoTARsPwBN+l6GAugdnO0ZJ5LyV/bURk2h6mT35AXkOpDVeLBTQttsuKnC DuXvlm3UhYTMfRVvtduiqkoEHKqNj+59f679Ej/EqiGMc8SeO8S2jVkyv2xRaKEj o0xWLHGdCcnugP6KX1Lsvdg2T82Yw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeefuddgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 17 Jun 2021 11:41:35 -0400 (EDT) From: Thomas Monjalon To: Christian Ehrhardt Cc: dev , Nithin Dabilpuram , "Burakov, Anatoly" Date: Thu, 17 Jun 2021 17:41:32 +0200 Message-ID: <11438480.ovEy26AHih@thomas> In-Reply-To: <465cd57b-f76e-4834-efab-9cb61d035f30@intel.com> References: <20210601054247.1540154-1-christian.ehrhardt@canonical.com> <20210601082825.1604489-1-christian.ehrhardt@canonical.com> <465cd57b-f76e-4834-efab-9cb61d035f30@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] vfio: fix stdbool usage without include X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/06/2021 13:06, Burakov, Anatoly: > On 01-Jun-21 9:28 AM, Christian Ehrhardt wrote: > > This became visible by backporting the following for the 19.11 stable tree: > > c13ca4e8 "vfio: fix DMA mapping granularity for IOVA as VA" > > > > The usage of type bool in the vfio code would require "#include > > ", but rte_vfio.h has no direct paths to stdbool.h. > > It happens that in eal_vfio_mp_sync.c it comes after "#include > > ". > > > > And rte_log.h since 20.05 includes stdbool since this change: > > 241e67bfe "log: add API to check if a logtype can log in a given level" > > and thereby mitigates the issue. > > > > It should be safe to include stdbool.h from rte_vfio.h itself > > to be present exactly when needed for the struct it defines using that > > type. > > > > Fixes: c13ca4e81cac ("vfio: fix DMA mapping granularity for IOVA as VA") > > > > Signed-off-by: Christian Ehrhardt > > > Acked-by: Anatoly Burakov Applied, thanks.