* [PATCH 1/1] test/hash: fix error log output
@ 2023-09-12 11:52 Min Zhou
2023-09-13 7:30 ` Stephen Hemminger
2023-11-23 0:44 ` Thomas Monjalon
0 siblings, 2 replies; 4+ messages in thread
From: Min Zhou @ 2023-09-12 11:52 UTC (permalink / raw)
To: yipeng1.wang, sameh.gobriel, bruce.richardson,
vladimir.medvedkin, pablo.de.lara.guarch, zhoumin
Cc: dev
Caught while running meson test:
hash creation failedTest Failed
Add missing \n.
Fixes: 0eb3726ebcf ("test/hash: add test for read/write concurrency")
Signed-off-by: Min Zhou <zhoumin@loongson.cn>
---
app/test/test_hash_readwrite.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_hash_readwrite.c b/app/test/test_hash_readwrite.c
index 74ca13912f..4997a01249 100644
--- a/app/test/test_hash_readwrite.c
+++ b/app/test/test_hash_readwrite.c
@@ -162,7 +162,7 @@ init_params(int use_ext, int use_htm, int rw_lf, int use_jhash)
handle = rte_hash_create(&hash_params);
if (handle == NULL) {
- printf("hash creation failed");
+ printf("hash creation failed\n");
return -1;
}
--
2.39.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] test/hash: fix error log output
2023-09-12 11:52 [PATCH 1/1] test/hash: fix error log output Min Zhou
@ 2023-09-13 7:30 ` Stephen Hemminger
2023-09-13 9:23 ` zhoumin
2023-11-23 0:44 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2023-09-13 7:30 UTC (permalink / raw)
To: Min Zhou
Cc: yipeng1.wang, sameh.gobriel, bruce.richardson,
vladimir.medvedkin, pablo.de.lara.guarch, dev
On Tue, 12 Sep 2023 19:52:39 +0800
Min Zhou <zhoumin@loongson.cn> wrote:
> diff --git a/app/test/test_hash_readwrite.c
> b/app/test/test_hash_readwrite.c index 74ca13912f..4997a01249 100644
> --- a/app/test/test_hash_readwrite.c
> +++ b/app/test/test_hash_readwrite.c
> @@ -162,7 +162,7 @@ init_params(int use_ext, int use_htm, int rw_lf,
> int use_jhash)
> handle = rte_hash_create(&hash_params);
> if (handle == NULL) {
> - printf("hash creation failed");
> + printf("hash creation failed\n");
Errors should be writen to stderr, not stdout?
It looks like the hash test doesn't do that anywhere though.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] test/hash: fix error log output
2023-09-13 7:30 ` Stephen Hemminger
@ 2023-09-13 9:23 ` zhoumin
0 siblings, 0 replies; 4+ messages in thread
From: zhoumin @ 2023-09-13 9:23 UTC (permalink / raw)
To: Stephen Hemminger
Cc: yipeng1.wang, sameh.gobriel, bruce.richardson,
vladimir.medvedkin, pablo.de.lara.guarch, dev
On Wed, Sep 13, 2023 at 3:30PM, Stephen Hemminger wrote:
> On Tue, 12 Sep 2023 19:52:39 +0800
> Min Zhou <zhoumin@loongson.cn> wrote:
>
>> diff --git a/app/test/test_hash_readwrite.c
>> b/app/test/test_hash_readwrite.c index 74ca13912f..4997a01249 100644
>> --- a/app/test/test_hash_readwrite.c
>> +++ b/app/test/test_hash_readwrite.c
>> @@ -162,7 +162,7 @@ init_params(int use_ext, int use_htm, int rw_lf,
>> int use_jhash)
>> handle = rte_hash_create(&hash_params);
>> if (handle == NULL) {
>> - printf("hash creation failed");
>> + printf("hash creation failed\n");
> Errors should be writen to stderr, not stdout?
> It looks like the hash test doesn't do that anywhere though.
Agree! The errors should go to stderr. However, there are many such
cases in app/test that errors were written to stderr. It requires huge
effort to fix them.
Regards,
Min
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] test/hash: fix error log output
2023-09-12 11:52 [PATCH 1/1] test/hash: fix error log output Min Zhou
2023-09-13 7:30 ` Stephen Hemminger
@ 2023-11-23 0:44 ` Thomas Monjalon
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2023-11-23 0:44 UTC (permalink / raw)
To: Min Zhou
Cc: yipeng1.wang, sameh.gobriel, bruce.richardson,
vladimir.medvedkin, pablo.de.lara.guarch, dev
12/09/2023 13:52, Min Zhou:
> Caught while running meson test:
> hash creation failedTest Failed
>
> Add missing \n.
>
> Fixes: 0eb3726ebcf ("test/hash: add test for read/write concurrency")
>
> Signed-off-by: Min Zhou <zhoumin@loongson.cn>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-23 0:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-12 11:52 [PATCH 1/1] test/hash: fix error log output Min Zhou
2023-09-13 7:30 ` Stephen Hemminger
2023-09-13 9:23 ` zhoumin
2023-11-23 0:44 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).